feat(event-log): migrate data db column to longtext
#227
Conversation
| @@ -47,32 +47,39 @@ protected static function get_current_option_name() { | |||
| * @return void | |||
| */ | |||
| protected static function maybe_update_db() { | |||
| $db_version = get_option( self::get_current_option_name(), 0 ); | |||
| $db_version = absint( get_option( self::get_current_option_name(), 0 ) ); | |||
| update_option( self::get_current_option_name(), self::DB_VERSION ); | |||
There was a problem hiding this comment.
I think you want to also delete this line
There was a problem hiding this comment.
We still want the db version to be tracked so it runs dbDelta() if necessary.
There was a problem hiding this comment.
Nevermind, I now realize it's a duplicated line
|
On my site I ended up on an infinite loop trying to update the DB table when visiting the Event Log. Fixed by moving the Also tested deleting the table and checking if it would work well on the first table creation. It did :) |
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
|
🎉 This PR is included in version 2.8.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [2.8.0](v2.7.0...v2.8.0) (2025-03-18) ### Bug Fixes * **content-distribution:** pages table column ([#230](#230)) ([fe5fa5c](fe5fa5c)) ### Features * **content-distribution:** remove distribution on incoming post deletion ([#225](#225)) ([24a421a](24a421a)) * **content-distribution:** support page post type ([#228](#228)) ([1d21b4d](1d21b4d)) * **event-log:** migrate `data` db column to `longtext` ([#227](#227)) ([ef2353b](ef2353b))
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The introduction of content distribution requires the event log data column to hold contents much larger than 64kb. The column type should be migrated to
longtext. This PR also introduces the use of dbDelta() to manage table changes.Testing
trunk, publish a post ensuring it exceeds 64kb in text (you can generate text using https://lipsum.com/)wp option get newspack_db_version_event_logand confirm the value is2wp db columns wp_newspack_hub_event_logand confirmdataislongtext