PHPCS rule changes to account for VIP functions #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address some VIP PHPCS sniffs that recommend functions not available on the Newspack platform.
The approach taken is to change the messaging to inform the user that the code in question should be used with caution and it may be slow or uncached and to reduce the sniff to a warning so that it appears in the IDE.
I have also updated the linting command to bypass warnings so only actual errors will be triggered when the
lint
command is run either manually, by Husky or via an Action.There are a number of other sniffs from the VIP ruleset that will fire errors that I left alone as I think they are probably good to follow.
Closes: #9
Testing Instructions
wp_remote_get
fires no errors or warningnpm run lint
and confirm that none of the warnings are flagged