Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the cart, checkout pages use shortcodes on install #3699

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR makes sure new Newspack installs use the shortcode version of the Woo Cart and Checkout. The latter is required for PayPal Payments to work in the modal checkout; there may be other functionality that doesn't work 100% without these shortcodes, too.

See: 1200550061930446-as-1209066781737984

How to test the changes in this Pull Request:

  1. Apply this PR and run npm run release:archive to generate a zip of the updated plugin.
  2. Install this plugin on a fresh site, like a new Jurassic Ninja site.
  3. Activate Woo and let it run it's mini setup (you can skip the guided setup).
  4. Navigate to Pages and edit the Cart and Checkout pages; confirm they use the shortcode for the content, and not blocks.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 24, 2025
@laurelfulford laurelfulford requested a review from a team as a code owner January 24, 2025 17:54
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 30, 2025
@laurelfulford
Copy link
Contributor Author

Thanks @dkoo! 🎉

@laurelfulford laurelfulford merged commit 954e01b into trunk Feb 4, 2025
9 checks passed
@laurelfulford laurelfulford deleted the fix/use-shortcodes-on-woo-install branch February 4, 2025 16:27
Copy link

github-actions bot commented Feb 4, 2025

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-changelog [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants