Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ia): clean up connections #3708

Open
wants to merge 2 commits into
base: epic/ia
Choose a base branch
from
Open

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Jan 29, 2025

All Submissions:

Changes proposed in this Pull Request:

Removes all references and code for the deprecated "Connections" wizard. The Fivetran connection has also been deprecated and completely removed (see p1714594679090649/1714590233.021889-slack-C06MPMZMF29)

How to test the changes in this Pull Request:

  1. Checkout this branch, build the js, and confirm there are no errors
  2. Navigate to "Newspack -> Settings"
  3. With Newspack Manager configured, confirm you're able to connect and disconnect Google OAuth
  4. Confirm you can change options in all sections of the "Connections" tab without issues
  5. Navigate to all the other tabs and confirm no API errors pop up (no regression by removing the files)
  6. Navigate to "Newspack -> Dashboard" and also confirm there are no API errors

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe marked this pull request as ready for review January 30, 2025 18:10
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 30, 2025 18:10
@miguelpeixe miguelpeixe self-assigned this Jan 30, 2025
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 30, 2025
@miguelpeixe miguelpeixe requested a review from dkoo January 30, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant