-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic local storybook implementation for newspack-ui #3770
Open
thomasguillot
wants to merge
7
commits into
trunk
Choose a base branch
from
add/storybook-base
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7aa2f14
to
f4dd9a5
Compare
ad6665f
to
00694ca
Compare
00694ca
to
4315e2d
Compare
@laurelfulford Why was the default size for icon-only buttons set to x-small, while regular buttons default to medium? I’ve updated this behaviour so that all buttons now default to medium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Introduces a new Storybook setup for Newspack UI components
/storybook
directory at the root levelCreates initial component stories:
Badge
Button
Segmented Control
Change the default size of the icon-only button to be
medium
, just like a regular button.Note: My goal is to ultimately have a dedicated Github page.
How to test the changes in this Pull Request:
Install and run Storybook:
Storybook should open at http://localhost:6006
In Storybook's sidebar, verify:
Test Badge component:
Test Button component:
Test Segmented Control component:
Verify documentation:
Check if the Reader Activation modals and elements are sized correctly
Other information: