Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Path to Autoloader #3808

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix: Path to Autoloader #3808

merged 1 commit into from
Mar 26, 2025

Conversation

ronchambers
Copy link
Collaborator

@ronchambers ronchambers commented Mar 7, 2025

All Submissions:

Changes proposed in this Pull Request:

Changes the main autoloader require path from relative to __DIR__. PHP can confuse relative paths in some contexts to mean the path of the currently running script and not the included file's path.

How to test the changes in this Pull Request:

  1. Verify the plugin works as a normal wordpress plugin.
  2. Verify the plugin's CLI commands still work.
  3. Verify phpunit tests still work.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ronchambers ronchambers marked this pull request as ready for review March 10, 2025 16:14
@ronchambers ronchambers requested a review from a team as a code owner March 10, 2025 16:14
@ronchambers ronchambers requested a review from leogermani March 10, 2025 16:17
@ronchambers
Copy link
Collaborator Author

ronchambers commented Mar 10, 2025

@leogermani - Not a huge deal, (I have a work around already in place for my code Automattic/newspack-migration-tools#60 ), but the above PR change to __DIR__ is good idea to do anyway. Thanks!

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ronchambers!

@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Mar 19, 2025
@ronchambers ronchambers merged commit 97fa24a into trunk Mar 26, 2025
8 checks passed
@ronchambers ronchambers deleted the fix/path-to-autoload branch March 26, 2025 21:23
Copy link

Hey @ronchambers, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants