Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp-sync): add constant contact support #3832

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Mar 14, 2025

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/1/26890605006346/project/1206274567818686/task/1209600501830288?focus=true

This PR adds ESP sync support for Constant Contact. We also take advantage of the ESP sync method when changing emails now that CC will be supported by our ESP Sync class.

Screenshot 2025-03-14 at 12 35 52

How to test the changes in this Pull Request:

  1. As admin, navigate to Newspack > Engagement > Newsletters, and set the site ESP to Contact Contact (with valid creds)
  2. Navigate to Newspack > Engagment > Show Advanced Settings > Email Service Provider (ESP) Advanced Settings
  3. Confirm you are able to set a Master List for Constant Contact
  4. As a new reader, register for a new account via the auth modal
  5. Either check the site logs for the contact sync, or go to constant contact dashboard and verify the contact was added
  6. As the reader again, purchase a recurring donation
  7. Again, either check the site logs for the contact sync, or go to constant contact dashboard and verify the contact was updated accordingly

Testing Email Change

  1. As the same reader, navigate to My Account > Account details
  2. Update the email address, and verify via the verification email
  3. One final time, check the site logs or contact contact dashboard for update

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review March 14, 2025 20:19
@chickenn00dle chickenn00dle requested a review from a team as a code owner March 14, 2025 20:19
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant