fix(ia): refresh on audience setup complete #3839

miguelpeixe · 2025-03-17T20:43:15Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

1205919985867982-as-1209464932054174/f

After the audience setup, a full page refresh is required. The current approach runs only a window.location.replace() which will not do a full page load if the replacement is just a hash change.

This PR forces a reload after the location is replaced.

How to test the changes in this Pull Request:

Go through a fresh Audience setup flow
Confirm you're redirected to the audience home wizard on completion and you get the following notice along with all the tabs unlocked:

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

…dditional-brands

…3495) * feat(ia-admin-header-selected): Allow ability to force selected tab * Update src/wizards/admin-header/index.tsx Co-authored-by: Jared Rethman <[email protected]> --------- Co-authored-by: Jared Rethman <[email protected]>

…brands feat(ia): settings additional brands

…ging fix: only apply merging to plain objects

Co-authored-by: Miguel Peixe <[email protected]>

feat(ras): allow skipping prerequisites; avoid dead end in onboarding

fix(recaptcha): remove v3 from heading; preserve settings on toggle

…3761)

This PR adds the suppression tab back into the Advertising wizard

chickenn00dle

This fixes the issue, but now this introduces some strangeness in the UI. After completing setup, the page appears to reload twice as a result of calling replace and then reload:

Screen.Recording.2025-03-18.at.12.34.39.mov

Maybe we can replace both of these with window.location.href = url?

miguelpeixe · 2025-03-19T18:44:09Z

Maybe we can replace both of these with window.location.href = url?

That will have the same behavior as .replace() for hash changes.

How about 7318b60?

chickenn00dle

How about 7318b60?

Thanks for clarifying! I am still seeing this strange double reload in the UI with this change:

Screen.Recording.2025-03-19.at.14.56.06.mov

It would be great if we could remain in the completed card until the reload triggers.

miguelpeixe · 2025-03-19T19:02:50Z

Hmm, that's strange. I can't reproduce it. Which browser is that?

chickenn00dle · 2025-03-19T19:05:55Z

This is on Firefox 136.0.2

jaredrethman and others added 30 commits October 23, 2024 15:49

feat: pr feedback - resetError on location change

920a27a

Merge remote-tracking branch 'origin/epic/ia' into feat/ia-settings-a…

a9705bc

…dditional-brands

Fix(epic-ia): hidden menu on php8 (#3493)

6cc6041

Merge pull request #3462 from Automattic/feat/ia-settings-additional-…

a766df8

…brands feat(ia): settings additional brands

refactor: make css class global

6cced4f

feat: add description prop to WizardsTab component

da928a6

feat: wrap in WizardsTab component

bd85a45

refactor: name change /audience-configuration to /audience

3ff7fa3

fix: only apply merging to plain objects

293620c

Merge remote-tracking branch 'origin/epic/ia' into feat/ia-audience

84d4d43

Merge pull request #3503 from Automattic/fix/wizardapifetch-cache-mer…

d2dc24b

…ging fix: only apply merging to plain objects

Merge remote-tracking branch 'origin/epic/ia' into feat/ia-audience

fe1d154

refactor: allow multiple react apps through a single directory

035075f

fix: ci / eslint

2de1d80

feat(ia): newsletters (#3490)

8ad5986

Co-authored-by: Miguel Peixe <[email protected]>

fix(ia): dashboard newsletters settings link (#3515)

8ae081d

Merge remote-tracking branch 'origin/epic/ia' into feat/ia-audience

359065f

feat: add reader activation campaign link

ca7d05b

Merge branch 'trunk' into epic/ia

39b46d9

feat: wip fixing newsletter enpoint

7f90d67

Merge remote-tracking branch 'origin/epic/ia' into feat/ia-audience

a90bfd4

fix(dashboard): check theme mod key (#3519)

1609d52

feat: update esp href for ras

f631e13

feat: update newsletters endpoint

5d54aec

feat: update recaptcha href

eb26f31

feat(ia-listings): IA for Listings Plugin (#3483)

5781860

Co-authored-by: Miguel Peixe <[email protected]>

Merge remote-tracking branch 'origin/epic/ia' into feat/ia-audience

52bb202

feat: text changes

7812cc6

refactor: final prep for review

bd8c799

dkoo and others added 19 commits February 11, 2025 13:28

feat: use Modal component instead of browser for confirmation

17a8223

feat: more flexible confirmation modal in WithWizard HOC

3dbec2d

Merge branch 'trunk' into epic/ia

4b63f45

fix(action-card): remove border between consecutive child sections

06ba10b

Merge pull request #3738 from Automattic/fix/ras-setup-avoid-dead-end

f89890c

feat(ras): allow skipping prerequisites; avoid dead end in onboarding

fix(ia): skip cache on google oauth flow (#3743)

baad1b2

Merge pull request #3739 from Automattic/fix/recaptcha-ui

470f385

fix(recaptcha): remove v3 from heading; preserve settings on toggle

feat: update brand colours (#3732)

283aaa9

Merge branch 'trunk' into epic/ia

3d57bd5

Merge branch 'trunk' into epic/ia

4cf3bef

fix(ia): newsletters component for the setup wizard (#3749)

e7025a0

fix(ia): handle trashed donation products and avoid creating dupes (#…

9459c71

…3761)

Merge branch 'trunk' into epic/ia

318de15

Merge branch 'trunk' into epic/ia

464ba70

fix(ia): re-add suppression advertising settings (#3806)

2e56dfe

This PR adds the suppression tab back into the Advertising wizard

fix: merge issues

3f3b622

fix: make sure segments scroll to top on load (#3827)

00dc02e

fix(ia): audience wizard without activation

aa36bfc

fix(ia): refresh on audience setup complete

02afbdd

miguelpeixe added [Status] Needs Review The issue or pull request needs to be reviewed Information Architecture labels Mar 17, 2025

miguelpeixe self-assigned this Mar 17, 2025

miguelpeixe requested a review from a team as a code owner March 17, 2025 20:43

chickenn00dle requested changes Mar 18, 2025

View reviewed changes

fix: clear hash and reload instead of location change

7318b60

chickenn00dle requested changes Mar 19, 2025

View reviewed changes

Base automatically changed from epic/ia to trunk March 26, 2025 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ia): refresh on audience setup complete #3839

fix(ia): refresh on audience setup complete #3839

miguelpeixe commented Mar 17, 2025 •

edited

Loading

chickenn00dle left a comment

miguelpeixe commented Mar 19, 2025

chickenn00dle left a comment

miguelpeixe commented Mar 19, 2025

chickenn00dle commented Mar 19, 2025

fix(ia): refresh on audience setup complete #3839

Are you sure you want to change the base?

fix(ia): refresh on audience setup complete #3839

Conversation

miguelpeixe commented Mar 17, 2025 • edited Loading

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

chickenn00dle left a comment

Choose a reason for hiding this comment

miguelpeixe commented Mar 19, 2025

chickenn00dle left a comment

Choose a reason for hiding this comment

miguelpeixe commented Mar 19, 2025

chickenn00dle commented Mar 19, 2025

miguelpeixe commented Mar 17, 2025 •

edited

Loading