fix(integrations): sync reader-account deletion to ESP

[chickenn00dle]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

When a reader deletes their account, Newspack is supposed to propagate that deletion to the connected ESP (Mailchimp / ActiveCampaign / Constant Contact). At some point that stopped working — deletions were silently swallowed and the contact lingered in the ESP forever. This PR fixes that, and adds per-integration controls so publishers can choose what "deletion" actually means for each ESP.

dsgnews-126-deletion-sync-demo.webm

What changed for publishers

A new section appears on every integration's configure page under Audience → Integrations → Configure:

• Sync user account deletion — a checkbox (on by default) that controls whether reader deletions reach this integration at all.
• How to sync deletion — appears only when the checkbox is on, with two options:
  • Delete contact immediately — removes the contact from the ESP entirely. This is the default and matches the old behavior.
  • Flag with metadata; integration decides — leaves the contact in the ESP, but stamps a new NP_Account_Deleted field on it with the deletion timestamp. Publishers can wire their own automation (a Mailchimp journey, an ActiveCampaign automation, etc.) to act on it however they like — archive, tag, unsubscribe, anything.

Sites that have already opted in to the legacy deletion sync (sync_esp_delete = true) automatically map to "delete immediately"; sites that had it off automatically map to the unchecked state. No publisher action required.

Closes DSGNEWS-126.

How to test the changes in this Pull Request:

Spin up an isolated env and connect a real ESP so outbound calls actually leave the box:

n env create dsgnews-126 --worktree newspack-plugin:fix/integrations-sync-deletion --up
n setup --env dsgnews-126 --yes

Then connect Newspack Newsletters to a test list on Mailchimp / ActiveCampaign / Constant Contact.

For each test below, create a reader (e.g. via My Account registration), confirm the contact landed in your ESP list, then delete the reader via the WP admin Users screen or My Account → Delete Account.

1. Default — Delete immediately. Don't change any settings. After deleting the reader, the contact should be removed from the ESP.
2. Flag mode. Go to Audience → Integrations → Newsletter ESP → Configure. Keep the "Sync user account deletion" checkbox on; switch "How to sync deletion" to Flag with metadata; integration decides. Delete a fresh reader. The contact should stay in the ESP, with a new NP_Account_Deleted field carrying a Y-m-d H:i:s timestamp.
3. Sync off. Uncheck "Sync user account deletion" — the "How to sync deletion" select should disappear. Delete a fresh reader. The contact should remain untouched in the ESP.
4. UI reactivity. On the configure page, toggle the checkbox a few times — the "How to sync deletion" select should show/hide instantly without needing to save.

Legacy sites. If a site is still on the legacy metadata mode, the old code path runs instead of the new dispatcher. Verify deletion still propagates and that the sync_esp_delete boolean is honored.

Automated tests:

n test-php --filter Test_Account_Deletion
n test-php --filter Newspack_Test_Contact_Sync_Connector
n test-php --filter Newspack_Test_Data_Events_Listeners_Deletion
n test-php --filter Test_Esp

Technical details for reviewers

Root cause of the bug. Both deletion event handlers read $data['user']['data']['user_email']. The listeners passed a WP_User object whose ArrayAccess::offsetGet('data') returns null, so the isset() guards short-circuited and both handlers returned early without syncing.

Listener fix. reader_deleted and reader_delete_sync now emit email as a top-level primitive, consistent with peer listeners (reader_logged_in, reader_verified).

Handler split by metadata version. Today both the legacy reader_deleted and the v1 reader_delete_sync handlers register on every site and both fire on delete_user. Now Contact_Sync_Connector::register_handlers() registers only one of the two, gated on Sync\Metadata::get_version(). Stops double-processing.

Framework additions:

• Integration::delete_contact( $email ) — new base method, default WP_Error('not_implemented'). ESP overrides it to call Newspack_Newsletters_Contacts::delete().
• Integration::get_account_deletion_fields() — auto-appended to every integration's settings via get_settings_fields(). Provides the two new fields described above. Includes lazy migration from sync_esp_delete via $legacy_option_map.
• Contact_Sync::handle_account_deletion() — new central dispatcher called from reader_delete_sync. Iterates active integrations and routes each one according to its own settings. Fires newspack_sync_contact_failed on errors (with a mode discriminator so Alert_Manager can tell delete-mode failures from flag-mode ones) and writes per-integration outcomes to the current ActionScheduler audit log, matching the patterns in push_to_integrations.
• account_deleted metadata is re-injected after prepare_contact() with the integration's prefix (so it survives the v1 outgoing-fields filter). Format matches peer datetime metadata (Y-m-d H:i:s, Title_Case_With_Underscores key).
• Frontend: small fieldIsVisible predicate in configure-view.js honors a new condition shape on field declarations — generic enough that other integrations can use it too.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[Copilot]

Pull request overview

This PR fixes reader-account deletion syncing to ESP/integrations and adds configurable per-integration deletion behavior.

Changes:

• Emits deletion event payloads with top-level email and gates legacy vs v1 deletion handlers by metadata version.
• Adds account-deletion settings and a central deletion dispatcher supporting hard-delete or metadata-flag modes.
• Adds PHPUnit coverage, fixtures, and newsletter mocks for deletion routing and ESP deletion behavior.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
includes/data-events/listeners.php	Sends deleted reader email as a primitive payload field.
includes/data-events/connectors/class-contact-sync-connector.php	Gates deletion handlers and routes v1 deletions to the new dispatcher.
includes/reader-activation/sync/class-contact-sync.php	Adds account deletion dispatch across active integrations.
includes/reader-activation/integrations/class-integration.php	Adds deletion settings and default delete_contact() API.
includes/reader-activation/integrations/class-esp.php	Removes legacy deletion setting and implements ESP contact deletion.
includes/reader-activation/integrations/README.md	Documents deletion APIs, settings, and conditional fields.
src/wizards/audience/views/integrations/configure-view.js	Adds conditional field visibility support.
tests/mocks/newsletters-mocks.php	Extends newsletter mocks with delete/upsert/update-list call tracking.
tests/unit-tests/data-events/class-contact-sync-connector.php	Tests handler registration and deletion connector behavior.
tests/unit-tests/data-events/class-listeners-deletion.php	Tests deletion listener payload shape.
tests/unit-tests/integrations/class-deletion-spy-integration.php	Adds a spy integration fixture for deletion routing tests.
tests/unit-tests/integrations/class-test-account-deletion.php	Tests base deletion settings, migration, routing, and failure hooks.
tests/unit-tests/integrations/class-test-esp.php	Tests ESP delete delegation and removal of legacy setting declaration.
tests/unit-tests/reader-activation-sync.php	Adjusts reader-sync constant handling in tests.

Comments suppressed due to low confidence (1)

includes/reader-activation/integrations/class-esp.php:173

• The ESP settings override now only adds provider-specific fields and metadata fields, so the new sync_account_deletion and account_deletion_handling fields appended by the base class are filtered out of the configure API response. That means the per-integration deletion controls described by this PR won't appear for the Newsletter ESP integration, leaving publishers unable to change these settings from the UI.

		$metadata_keys = array_column( $this->get_metadata_fields(), 'key' );
		foreach ( $config as $field ) {
			if ( in_array( $field['key'], $metadata_keys ) ) {
				$enriched[] = $config[ $field['key'] ];
			}
		}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.