Up Next History - Show episode details and restore #3797

ashiagr · 2025-03-20T06:27:35Z

Description

This displays episodes within "Up Next" history and allows restoring them into the "Up Next" queue.

Testing Instructions

Test.1 Restore "Up Next"

Repeat steps from Test.1 in Up Next History - Snapshot and display history entries #3796 to create a snapshot of "Up Next" queue
Tap a snapshot entry from Profile -> Settings -> Restore from local history -> Up Next History
✅ Notice that episodes are shown for that snapshot
Tap "Restore" in the toolbar and confirm
✅ Notice that episodes are added to the end of "Up Next" queue

Test.2 Delete entries older than 14 days

Change below line in UpNextHistoryManagerImpl
private val periodOfSnapshot: Duration = Duration.ofDays(14)
to
private val periodOfSnapshot: Duration = Duration.ofMinutes(1)
Fresh install the app
Add episodes to queue
Clear queue
Notice that snapshot entry is present in Profile -> Settings -> Restore from local history -> Up Next History
Wait for a minute
Repeat steps 4-5
✅ Notice that a new snapshot is created and previous snapshot entry is deleted in Profile -> Settings -> Restore from local history -> Up Next History

Screenshots or Screencast

up_next_history_restore.mp4

Checklist

If this is a user-facing change, I have added an entry in CHANGELOG.md
Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
I have considered whether it makes sense to add tests for my changes
All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previews
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

with different themes
with a landscape orientation
with the device set to have a large display and font size
for accessibility with TalkBack

dangermattic · 2025-03-20T06:28:19Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2025-03-20T06:29:17Z

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.

	App Name	📱 Mobile
	Build Type	debugProd
	Commit	`8e4121a`
	Direct Download	`pocketcasts-app-prototype-build-pr3797-8e4121a.apk`

📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.

	App Name	🚗 Automotive
	Build Type	debugProd
	Commit	`8e4121a`
	Direct Download	`pocketcasts-automotive-prototype-build-pr3797-8e4121a.apk`

📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.

	App Name	⌚ Wear
	Build Type	debugProd
	Commit	`8e4121a`
	Direct Download	`pocketcasts-wear-prototype-build-pr3797-8e4121a.apk`

(cherry picked from commit ca9c952)

(cherry picked from commit ce27a0e) (cherry picked from commit 8573a53)

(cherry picked from commit 24b9235) (cherry picked from commit 75fd3fe)

(cherry picked from commit bcc1155) (cherry picked from commit e8b6090)

(cherry picked from commit 447a5c3)

geekygecko · 2025-03-21T00:30:51Z

...es/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/history/HistoryFragment.kt

+                        }
+                    UpNextHistoryDetailsPage(
+                        date = date,
+                        onRestoreClick = ::showUpNextRestoreConfirmationDialog,


This isn't a big deal, so feel free to ignore it, but if I don't have anything currently playing or in my Up Next, the explanation text doesn't really make sense. Maybe it can just be restored.

Good point! Why add an extra step? Flow updated in fb33c2e

geekygecko · 2025-03-21T00:32:42Z

...main/java/au/com/shiftyjelly/pocketcasts/settings/history/upnext/UpNextHistoryDetailsPage.kt

+    Column {
+        ThemedTopAppBar(
+            title = formatDate(date),
+            bottomShadow = true,


Suggested change

bottomShadow = true,

I think it looks more modern to not have the drop shadow. Feel free to ignore if you disagree.

geekygecko · 2025-03-21T00:35:51Z

...main/java/au/com/shiftyjelly/pocketcasts/settings/history/upnext/UpNextHistoryDetailsPage.kt

+                text = formattedDuration,
+                maxLines = 1,
+                modifier = Modifier.padding(top = 4.dp),
+            )


Can we make these look more like the episode row from filters?

Updated in 3980833

geekygecko · 2025-03-21T00:42:27Z

...main/java/au/com/shiftyjelly/pocketcasts/settings/history/upnext/UpNextHistoryDetailsPage.kt

+                useEpisodeArtwork = state.useEpisodeArtwork,
+            )
+        }
+    }


I can't see the bottom episode and the top episode is being cut off early.

I can't see the bottom episode

I see that bottom insets are added to the view. I can't reproduce it. Maybe padding updates for the top row fixed it.

Screen_recording_20250321_104825.mp4

# Conflicts: # modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/history/HistoryFragment.kt # modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/history/upnext/UpNextHistoryPage.kt # modules/services/localization/src/main/res/values/strings.xml

ashiagr added 3 commits March 19, 2025 11:11

Add up next history table

1717e4e

Add up next history dao

5bc756b

Add up next history manager

68b3051

ashiagr added [Type] Feature Adding a new feature. HACK week Developed as a part of HACK week [Area] Up Next [Area] Settings labels Mar 20, 2025

ashiagr added this to the 7.86 milestone Mar 20, 2025

ashiagr added 6 commits March 20, 2025 12:18

Fix test

c5a9047

(cherry picked from commit ca9c952)

Snapshot up next on clear queue

6450f57

(cherry picked from commit ce27a0e) (cherry picked from commit 8573a53)

Snapshot up next on sync

14d5dec

(cherry picked from commit 24b9235) (cherry picked from commit 75fd3fe)

Add entry point

973ec23

(cherry picked from commit bcc1155) (cherry picked from commit e8b6090)

Add up next history page

dc4005d

(cherry picked from commit 447a5c3)

Fix formatting

65defa0

ashiagr force-pushed the task/up_next_history_page_ branch from 447a5c3 to 65defa0 Compare March 20, 2025 06:51

ashiagr added 3 commits March 20, 2025 12:35

Add vm tests

70e7304

Add up next history details page

75f42ef

Fix formatting

46a1c71

ashiagr force-pushed the task/up_next_history_details_and_restore branch from f372f67 to 46a1c71 Compare March 20, 2025 07:23

ashiagr added the do not merge label Mar 20, 2025

ashiagr marked this pull request as ready for review March 20, 2025 07:36

ashiagr requested a review from a team as a code owner March 20, 2025 07:36

ashiagr requested review from geekygecko and removed request for a team March 20, 2025 07:36

geekygecko approved these changes Mar 21, 2025

View reviewed changes

ashiagr added 3 commits March 21, 2025 10:52

Remove toolbar shadow

cef5b5e

Update episode row style

3980833

Restore directly if up next is empty

fb33c2e

Base automatically changed from task/up_next_history_page_ to main March 24, 2025 03:42

ashiagr added 2 commits March 24, 2025 09:14

Add changelog

8e4121a

ashiagr removed the do not merge label Mar 24, 2025

ashiagr merged commit 4a442f2 into main Mar 24, 2025
19 checks passed

ashiagr deleted the task/up_next_history_details_and_restore branch March 24, 2025 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Up Next History - Show episode details and restore #3797

Up Next History - Show episode details and restore #3797

ashiagr commented Mar 20, 2025 •

edited

Loading

dangermattic commented Mar 20, 2025 •

edited

Loading

wpmobilebot commented Mar 20, 2025 •

edited

Loading

geekygecko Mar 21, 2025

ashiagr Mar 21, 2025

geekygecko Mar 21, 2025

geekygecko Mar 21, 2025

ashiagr Mar 21, 2025

geekygecko Mar 21, 2025

ashiagr Mar 21, 2025

Up Next History - Show episode details and restore #3797

Up Next History - Show episode details and restore #3797

Conversation

ashiagr commented Mar 20, 2025 • edited Loading

Description

Testing Instructions

Test.1 Restore "Up Next"

Test.2 Delete entries older than 14 days

Screenshots or Screencast

Checklist

I have tested any UI changes...

dangermattic commented Mar 20, 2025 • edited Loading

wpmobilebot commented Mar 20, 2025 • edited Loading

geekygecko Mar 21, 2025

Choose a reason for hiding this comment

ashiagr Mar 21, 2025

Choose a reason for hiding this comment

geekygecko Mar 21, 2025

Choose a reason for hiding this comment

geekygecko Mar 21, 2025

Choose a reason for hiding this comment

ashiagr Mar 21, 2025

Choose a reason for hiding this comment

geekygecko Mar 21, 2025

Choose a reason for hiding this comment

ashiagr Mar 21, 2025

Choose a reason for hiding this comment

ashiagr commented Mar 20, 2025 •

edited

Loading

dangermattic commented Mar 20, 2025 •

edited

Loading

wpmobilebot commented Mar 20, 2025 •

edited

Loading