Skip to content

Use episode artwork when sharing #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Use episode artwork when sharing #3397

wants to merge 2 commits into from

Conversation

@bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Aug 4, 2025 •
edited
Loading

Fixes PCIOS-72

Before After

To test

  • Enable Settings > Appearance > "Use Episode Artwork"

Currently Playing

  • Play an episode with episode artwork. Like the most recent The Joe Rogan Experience episodes.
  • Share the currently playing episode
  • Select the "Episode" share type
  • Verify that the image shown is the episode and not podcast artwork

Random Episode

  • Navigate to an episode from the Podcast page
  • Select the "Episode" share type
  • Verify that the image shown is the episode and not podcast artwork

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus requested a review from a team as a code owner August 4, 2025 21:30
@bjtitus bjtitus requested review from danielebogo and removed request for a team August 4, 2025 21:30
@bjtitus bjtitus added this to the 7.96 milestone Aug 4, 2025
@bjtitus bjtitus added the [Type] Enhancement Improve an existing feature. label Aug 4, 2025
@bjtitus bjtitus marked this pull request as draft August 4, 2025 22:53
@bjtitus bjtitus removed the request for review from danielebogo August 4, 2025 22:53
danielebogo
danielebogo reviewed Aug 6, 2025
View reviewed changes
podcasts/Sharing/ShareImageView.swift
Comment on lines +140 to +151
if Settings.loadEmbeddedImages,
let episodeUuid = info.episodeUuid,
ImageManager.sharedManager.subscribedPodcastsCache.isCached(forKey: episodeUuid) {
let path = ImageManager.sharedManager.subscribedPodcastsCache.cachePath(forKey: episodeUuid)
KFImage(URL(fileURLWithPath: path))
.resizable()
.clipShape(RoundedRectangle(cornerRadius: 8))
} else if let podcastUuid = info.podcastUuid {
KFImage(ImageManager.sharedManager.podcastUrl(imageSize: .page, uuid: podcastUuid))
.resizable()
.clipShape(RoundedRectangle(cornerRadius: 8))
}
Copy link
Contributor

@danielebogo danielebogo Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjtitus We have AsyncImageView which wraps the KFImage

@pocketcasts pocketcasts modified the milestones: 7.96, 7.97 Aug 18, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Aug 18, 2025

Version 7.96 has now entered code-freeze, so the milestone of this PR has been updated to 7.97.

@pocketcasts pocketcasts modified the milestones: 7.97, 7.98 Sep 1, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Sep 1, 2025

Version 7.97 has now entered code-freeze, so the milestone of this PR has been updated to 7.98.

@pocketcasts pocketcasts modified the milestones: 7.98, 7.99 Sep 15, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Sep 15, 2025

Version 7.98 has now entered code-freeze, so the milestone of this PR has been updated to 7.99.

@pocketcasts pocketcasts modified the milestones: 7.99, 7.100 Sep 29, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Sep 29, 2025

Version 7.99 has now entered code-freeze, so the milestone of this PR has been updated to 7.100.

@pocketcasts pocketcasts modified the milestones: 7.100, 7.101 Oct 14, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Oct 14, 2025

Version 7.100 has now entered code-freeze, so the milestone of this PR has been updated to 7.101.

@pocketcasts pocketcasts modified the milestones: 7.101, 7.102 Oct 27, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Oct 27, 2025

Version 7.101 has now entered code-freeze, so the milestone of this PR has been updated to 7.102.

@danielebogo danielebogo modified the milestones: 7.102, 8.0 Nov 10, 2025
@pocketcasts pocketcasts modified the milestones: 8.0, 8.1 Nov 11, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Nov 11, 2025

Version 8.0 has now entered code-freeze, so the milestone of this PR has been updated to 8.1.

@pocketcasts pocketcasts modified the milestones: 8.1, 8.2 Nov 26, 2025
@pocketcasts
Copy link
Contributor

pocketcasts commented Nov 26, 2025

Version 8.1 has now entered code-freeze, so the milestone of this PR has been updated to 8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielebogo danielebogo danielebogo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Type] Enhancement Improve an existing feature.

Projects

None yet

Milestone

8.2

Development

Successfully merging this pull request may close these issues.

4 participants

@bjtitus @pocketcasts @danielebogo