Skip to content

Conversation

@bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Dec 2, 2025

Fixes PCIOS-380

This changes two behaviors regarding downloads:

  • Any time a podcast is unsubscribed from the device, all downloads are removed regardless of playlist status. The user agrees to a prompt to explicitly remove them and this behavior was changed in Keep downloads & Up Next queue on unsubscribe #3538
  • Downloads are not removed when running the regular cleanup task if they are part of a manual playlist. This is because the Podcast info may have been fetched for display and we don't know the difference, so this would delete all episodes manually added from Discover from a podcast a user didn't subscribe to.

To test

Unsubscribe deletion

Must be signed in to account

  1. Subscribe to a podcast from Discover
  2. Unsubscribe from the podcast
  3. Navigate back to that podcast on Discover
  4. ✅ Ensure downloaded episodes are deleted

Non-subscribed Manual Playlist Episode

  1. Add an episode from Discover to a Manual playlist from a podcast you don’t subscribe to
  2. Download the episode
  3. Pull to refresh
  4. ✅ Ensure the download remains

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 2, 2025

1 Warning
⚠️ This PR is assigned to the milestone 8.1 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus marked this pull request as ready for review December 2, 2025 06:08
@bjtitus bjtitus requested a review from a team as a code owner December 2, 2025 06:08
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team December 2, 2025 06:08
@bjtitus bjtitus changed the base branch from trunk to release/8.1 December 2, 2025 06:08
@bjtitus bjtitus added this to the 8.1 ❄️ milestone Dec 2, 2025
@bjtitus bjtitus added the Downloads Issues related to the download feature label Dec 2, 2025
@bjtitus bjtitus force-pushed the bjtitus/delete-downloads-on-unsubscribe branch from f09c8d3 to 0b90c7e Compare December 2, 2025 06:17
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly.
Episode in manual playlists are not being deleted when refreshing.
:shipit:

@bjtitus bjtitus merged commit 7129936 into release/8.1 Dec 2, 2025
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/delete-downloads-on-unsubscribe branch December 2, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Downloads Issues related to the download feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants