Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataViews and replace table in settings #257

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

brookewp
Copy link
Contributor

🤞 Another attempt at #255 which was reverted in #256, but this includes an upgraded @wordpress/dependency-extraction-webpack-plugin which is required for the /wp build of DataViews as it's the first version to not extract it.

Copy link
Contributor

@maxschmeling maxschmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work! Let's merge and hope nothing blows up this time! 🚢

@brookewp brookewp merged commit 1fb693f into trunk Dec 19, 2024
9 checks passed
@brookewp brookewp deleted the try/dataviews-admin branch December 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants