url encode sheet name to fix invalid endpoint error #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszarate
approved these changes
Jan 15, 2025
chriszarate
pushed a commit
that referenced
this pull request
Jan 15, 2025
* url encode sheet name to fix invalid endpoint error * use bracket notation for defining JSON path for Google Sheets
chriszarate
added a commit
that referenced
this pull request
Jan 16, 2025
* initial changes * adding strengths and weaknesses * edits and renaming * another name change and airtable stuff * updating google sheets * adding screen shot * adding screen shot * adding shopify and Salesforce skeleton * final first-pass updates to tutorials * Airtable tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Google sheets tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Salesforce tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Shopify tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * HTTP tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Concepts grammatical fixes and formatting Signed-off-by: brookewp <[email protected]> * Tutorial docs formatting Signed-off-by: brookewp <[email protected]> * Remaining proof-read docs Signed-off-by: brookewp <[email protected]> * adding block-bindings document * cleaning up final changes from Workflows to Tutorials * Add links from concepts index page * Fix formatting * Reordering to reflect sequence of events and utility * Flesh out block registration options * small updates * updates to query * settings forms fixes (#297) * allow undefined values for handleOnChange to match allowed undefined in state values * allow adding invalid string in google credentials input * reset google spreadsheet and sheet inputs on credentials change * reset airtable base and tables on token change * update the register blocks function names in airtable conference event block registration * url encode sheet name to fix invalid endpoint error (#298) * url encode sheet name to fix invalid endpoint error * use bracket notation for defining JSON path for Google Sheets * Remove example glue code and example access tokens * Update "Conference events" example * Fix formatting * adding better type documentation * Fix block registration code example Signed-off-by: brookewp <[email protected]> * Add ServerSideRender package and types * Update Elden Ring Map example to Leaflet Map block To simplify, this block no longer uses register_remote_data_block or the Interactivity API. * fix typo and improve link by linking to a section of file * fix formatting * Update GitHub example * Update Google Sheets example * Minor example README updates * Update Shopify example * Restore linting to example code * Remove unused suppression * Update Beta warning * Update Zip code example * Update Art example * Fix typo * Add entrypoint README --------- Signed-off-by: brookewp <[email protected]> Co-authored-by: brookewp <[email protected]> Co-authored-by: chriszarate <[email protected]> Co-authored-by: Shekhar Wagh <[email protected]> Co-authored-by: Shekhar Wagh <[email protected]>
maxschmeling
added a commit
that referenced
this pull request
Jan 18, 2025
* initial changes * adding strengths and weaknesses * edits and renaming * another name change and airtable stuff * updating google sheets * adding screen shot * adding screen shot * adding shopify and Salesforce skeleton * final first-pass updates to tutorials * Airtable tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Google sheets tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Salesforce tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Shopify tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * HTTP tutorial grammatical fixes Signed-off-by: brookewp <[email protected]> * Concepts grammatical fixes and formatting Signed-off-by: brookewp <[email protected]> * Tutorial docs formatting Signed-off-by: brookewp <[email protected]> * Remaining proof-read docs Signed-off-by: brookewp <[email protected]> * adding block-bindings document * cleaning up final changes from Workflows to Tutorials * Add links from concepts index page * Fix formatting * Reordering to reflect sequence of events and utility * Flesh out block registration options * small updates * updates to query * settings forms fixes (#297) * allow undefined values for handleOnChange to match allowed undefined in state values * allow adding invalid string in google credentials input * reset google spreadsheet and sheet inputs on credentials change * reset airtable base and tables on token change * update the register blocks function names in airtable conference event block registration * url encode sheet name to fix invalid endpoint error (#298) * url encode sheet name to fix invalid endpoint error * use bracket notation for defining JSON path for Google Sheets * Remove example glue code and example access tokens * Update "Conference events" example * Fix formatting * adding better type documentation * Fix README typo * Slight rewording in Block Bindings docs * Slight rewording in Airtable tutorial * Reorder tutorials list to be alphabetical * Add more detail to the HTTP tutorial * Add Shopify steps for setting up API access * Formatting fixes * Move warning and use GitHub notice style * Remove outdated instructions * Remove link * Promote Next Steps * Remove footer (it's duplicated on remotedatablocks.com) * Fix tutorial links * Update code example links * Fix tutorials link * Small grammar fix * Update link to LICENSE (not a Markdown file) * Use absolute image references * query examples * finishing up output schema revisions * grammer stuff * Start of a Quickstart * extending extending * grammer changes * update to block patterns * fixing typo * start work on block registration * More content in the quickstart * Auto formatting --------- Signed-off-by: brookewp <[email protected]> Co-authored-by: Jacob Wayne Smith <[email protected]> Co-authored-by: brookewp <[email protected]> Co-authored-by: chriszarate <[email protected]> Co-authored-by: Shekhar Wagh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the following bug which led to error in case of the Google Sheet name containing spaces: -
URL Encoding the sheet name before appending it to the Google Sheets API URL to create the HTTPQuery endpoint solves the issue.
Fixes the bug columns with spaces for Google Sheets data sources are not being displayed in the Google Sheets settings page by using the brackets notation for the field paths in the output query mappings.
Links
Testing