Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the salesforce-d2c icon on the data sources page #392

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

ingeniumed
Copy link
Contributor

Description

Currently, if the data source is Salesforce the HTTP datasource icon is shown. The purpose os this PR is to fix that, and ensure the salesforce icon is correctly shown.

Testing

  • Setup salesforce as a source before you pull this branch down. Ensure that the icon is the HTTP one.
  • Now pull this branch down and see that the icon is updated to the salesforce one.

@ingeniumed ingeniumed self-assigned this Feb 25, 2025
Copy link

Test this PR in WordPress Playground.

Copy link
Contributor

@shekharnwagh shekharnwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the credentials to setup the salesforce d2c source, but code looks good. Thank you for fixing it!

@ingeniumed ingeniumed merged commit dfc8408 into trunk Feb 25, 2025
13 checks passed
@ingeniumed ingeniumed deleted the fix/salesforce-d2c-icon-on-datasources branch February 25, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants