ItemList: Add check for empty fields #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: brookewp <[email protected]>
Signed-off-by: brookewp <[email protected]>
|
Test this PR in WordPress Playground. |
Open
alecgeatches
approved these changes
Feb 27, 2025
chriszarate
reviewed
Feb 27, 2025
| fields: tableFields, | ||
| } ) ); | ||
| } | ||
| }, [ tableFields ] ); |
There was a problem hiding this comment.
The effect runs whenever tableFields changes. When does that happen? Or does it only run once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alecgeatches found that fields weren't showing for Salesforce after initiating a search.
This is because there are no results on the initial render for Salesforce. So the field value was remaining as an empty array even after searching/updating the view.
This adds a
useEffectto make sure that fields are updated if there are changes.