Bugfix: Loading state in DataViews when paginating #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when navigating through pages of results in DataViews, the user never sees a loading state. This is because the previous results continue to be passed to the component, which overrides the
loading
prop. This leads to some confusing "did it work?" UX:before.mov
Instead we can withhold the results when the request is loading:
after.mov
Also noticing some alignment issues for the pagination links, not sure if that's because of our overlay or not. cc: @brookewp