apply http data source service config to request #492
+197
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekharnwagh
force-pushed
the
vipcms-1226-use-generic-http-config
branch
from
3290192 to
4dc0902
Compare
|
Test this PR in WordPress Playground. |
The generic http data source supports authentication config in the service config. This was not applied to the request, which now happens.
shekharnwagh
force-pushed
the
vipcms-1226-use-generic-http-config
branch
from
4dc0902 to
f7e3291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic HTTP data source supports authentication configuration in the service config, including Bearer Token, Basic Auth, and API Key. Authentication headers are now properly applied to outgoing requests based on the configured authentication type -
Authorizationheader with valueBearer {token}Authorizationheader with valueBasic {base64_encoded_credentials}Authorizationheader ifadd_toisheader, or as a query parameter ifadd_toisqueryparams