Fix global button styles for colors and borders #7753
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
donnapep
force-pushed
the
fix/button-global-styles
branch
from
4637f90 to
e7cf660
Compare
|
Test the previous changes of this PR with WordPress Playground. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Proposed Changes
Previously, we were applying colours to the
.wp-block-buttonelement, which caused issues with colours not working when set through Global Styles. To address this, colour styles have been moved to.wp-block-button__linkto match what core does for the Buttons block.Testing Instructions
learning-mode-compat.scssisn't loaded for Course theme).New/Updated Hooks
Deprecated Code
Pre-Merge Checklist