Remove sustainer UI #1644
Merged
Remove sustainer UI #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces methods for testing.
Generated by 🚫 Danger |
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
khaykov
added
the
task
khaykov
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Thanks, @roundhill ! Looks good 👍
Do we want to also remove billing dependency (com.android.billingclient:billing:6.0.1) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the sustainer UI and related in-app-purchase code. I've opted to just remove everything, but if we think we might want to use the banners for something else in the future we could keep them around instead...
Test
Release
These changes do not require release notes.