Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for was_sustainer property to be an int. #1647

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add a check for was_sustainer property to be an int. #1647

merged 1 commit into from
Apr 10, 2024
+5 −1

Conversation

roundhill
Copy link
Contributor

Fix

Simperium may return a 1 or 0 int value for the was_sustainer property. I've added a check for that.

Test

  • Not much to test here, I've verified it is working on my device that has the flag enabled or disabled with 1, 0, true and false values.

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 10, 2024 •
edited
Loading

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@nsakaimbo nsakaimbo self-requested a review April 10, 2024 20:54
nsakaimbo
nsakaimbo approved these changes Apr 10, 2024
View reviewed changes
Copy link

@nsakaimbo nsakaimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a relatively straightforward change. 👍🏽 Thank you!

@roundhill roundhill added the task This issue is some sort of task or a spike of time not directly related to a feature. label Apr 10, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commit03ea04e
Direct Downloadsimplenote-android-prototype-build-pr1647-03ea04e-018ec9c8-6e9a-490a-a971-48e5a94f1992.apk

@roundhill roundhill merged commit c6f47e0 into trunk Apr 10, 2024
10 of 11 checks passed
@roundhill roundhill deleted the fix/was-sustainer-int-property branch April 10, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsakaimbo nsakaimbo nsakaimbo approved these changes

Assignees
No one assigned
Labels
task This issue is some sort of task or a spike of time not directly related to a feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roundhill @dangermattic @wpmobilebot @nsakaimbo