Merge release/2.34 into trunk #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `beta: true` by default and allowing it to remain so even with `track: production` resulted in a build without release notes which I am not able to update because of API/Fastlane implementation details such as the ones mentioned in: - fastlane/fastlane#22126 - fastlane/fastlane#21506 I could fix the issue by manually updating the release notes, but I'd like to verify the automation flow ASAP. As such, I'll follow this change with a new build.
This is a good security practice. In noticed the key location while looking into the CI failure at https://buildkite.com/automattic/simplenote-android/builds/388 Google Api Error: Invalid request - The caller does not have permission I doubt the error is due to the key location, but since I'm looking into the key, I thought I might as well fix its location and try again.
172 was uploaded form my dev machine to test the workaround in the previous commit.
…error" This reverts commit bbcab89.
See internal ref pMz3w-kLJ-p2 that shows the service account should now have the right credentials to upload metadata.
mokagio
reviewed
Sep 24, 2024
| plugins: [$CI_TOOLKIT_plugin] | ||
| plugins: [$CI_TOOLKIT_PLUGIN] |
There was a problem hiding this comment.
How did I miss this?! 🤦♂️
Generated by 🚫 Danger |
mokagio
reviewed
Sep 24, 2024
| "destination": ".configure-files/google-upload-credentials.json", | ||
| "destination": "~/.configure/simplenote-android/secrets/google-upload-credentials.json", |
There was a problem hiding this comment.
Moved the file out of the repo while I was at it...
mokagio
reviewed
Sep 24, 2024
| versionCode=174 |
There was a problem hiding this comment.
Had to iterate a few times due to missing permissions on the Play Console end.
mokagio
approved these changes
Sep 24, 2024
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging
release/2.34intotrunk.Via intermediate branch
merge/release-2.34-into-trunk, to help fix conflicts if any: