Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the domain used for prototypes #1714

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Change the domain used for prototypes #1714

merged 1 commit into from
Nov 7, 2024

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Nov 7, 2024

This PR swaps out the CloudFront domain to remove the safety warning shown in Chrome.

Testing

  1. Click the Direct Download link for the prototype builds from @wpmobilebot while using Chrome.
  2. Expect: The domain for the prototype build to be cdn.a8c-ci.services and not d2twmm2nzpx3bg.cloudfront.net.
  3. Expect: To not get a "Dangerous site" error like the one below after opening the link.

image

@twstokes twstokes added the tooling Related to anything that supports the building & maintaining of the project. label Nov 7, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commita61cdb4
Direct Downloadsimplenote-android-prototype-build-pr1714-a61cdb4-01930716-6b01-44d5-814a-463330bfcb55.apk

@twstokes twstokes requested a review from a team November 7, 2024 14:53
AliSoftware
AliSoftware approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@twstokes twstokes merged commit f924b88 into trunk Nov 7, 2024
16 checks passed
@twstokes twstokes deleted the task/prototype-domain branch November 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twstokes @dangermattic @wpmobilebot @AliSoftware