[Tooling] Update GitHub Actions #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
tooling
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
iangmaia
force-pushed
the
iangmaia/update-gradle-wrapper-validation
branch
from
f0820b4 to
cdb6b71
Compare
spencertransier
approved these changes
Dec 12, 2024
|
@iangmaia Approved to unblock, but is there a reason this change would affect the linting errors that Danger picked up? |
It's not related to these changes but they might have been dormant for some reason -- my guess is that the Linter didn't pick them up in a previous PR due to a bug (now fixed) that it would use a different Rubocop version than the one configured in the project Bundle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: p7H4VZ-59z-p2
Simplenote Android doesn't use one of the GitHub Actions about to have its older versions deprecated as
actions/upload-artifact,actions/download-artifactoractions/cache, but I used this opportunity to upgrade the Actiongradle/actions/wrapper-validationand to move the Buildkite Gradle Wrapper Validation to the Linter queue.