Skip to content

Update AppStoreStrings to mention English comma keywords requirement #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 22, 2021

App Store Connect requires keywords to be separated by "English comma, Chinese comma, or a mix of both". For consistency and simplicity, I specify only English comma here.

Test

Nothing to test, this change will be picked up as the new comment for translators in GlotPress.

Review

Only one developer required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

App Store Connect requires keywords to be separated by "English comma,
Chinese comma, or a mix of both". For consistency and simplicity, I
specify only English comma here.
@mokagio mokagio added the tooling Related to anything that supports the building & maintaining of the project. label Jun 22, 2021
@@ -61,7 +61,7 @@ msgid ""
msgstr ""

#. translators: Keywords used in the App Store search engine to find the app.
#. Delimit with a comma between each keyword. Limit to 100 characters including spaces and commas.
#. Delimit with an English comma between each keyword. Limit to 100 characters including spaces and commas.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mokagio mokagio marked this pull request as ready for review June 22, 2021 05:02
@mokagio mokagio requested a review from a team June 22, 2021 05:02
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯 for the mention of this in the translator comment.

I fail to remember, did we also implement a check in all the Fastfiles or in the action to at least warn us about any non-English comma accidentally used at beta/release time? i remember we talked about this but can't remember if we implemented it, and if so if we did it in all repos.

@mokagio mokagio added this to the 4.39 milestone Jun 23, 2021
@mokagio
Copy link
Contributor Author

mokagio commented Jun 23, 2021

Thank @AliSoftware 🙇

did we also implement a check in all the Fastfiles or in the action to at least warn us about any non-English comma accidentally used at beta/release time?

No, but it's a neat idea

i remember we talked about this but can't remember if we implemented it, and if so if we did it in all repos.

We talked about something similar in the context of adding a post-processing step to do the replacement here on the repo. Discussion breadcrumbs can be found in #1206.

My recollection of the discussion, and the place I'm currently at, is that:

  • Post-processing is okay at a temporary fix to unblock a time sensitive release; but
  • It's better to fix the issue at the source, i.e.: GlotPress

Your suggestion to add a check step during beta builds is great and in line with helping us fixing the issue at the GlotPress level 👍

As an aside, I did fix the current version of the Arabic keywords in GlotPress myself. Given the slow pace at which keywords get updated, we might not need the check for a while.

@mokagio mokagio merged commit a943aca into develop Jun 23, 2021
@mokagio mokagio deleted the english-comma-ar-strings branch June 23, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants