Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textkit 2: Fixed gesture recognizer so tapping into text does not fallback to text kit 1 #1691

Merged
merged 6 commits into from
Dec 28, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented Dec 21, 2024

Fix

In my previous PR with TextKit 2, #1690 , I added the basic setup for SPTextView to use Text Kit 2 if available, and I created a mechanism to fallback to text kit 1 without losing all formatting. However in that PR if you did anything other than view a note you were immediately dropped back into Text Kit 1.

In this PR I have updated gesture recognizer to not use layoutManager so the view does not drop back to text kit 1. This should allow you to tap into, interact with, edit, and save text while still in text kit 2.

Next up: Search

Test

  1. Select a note
  2. Tap on any part of the text and start typing in it. Do some basic editing of the note
  • confirm that you do not see is switching to TextKit 1 compatibility mode because its layoutManager was accessed in the console
  • Also smoke test iOS 16 or older to make sure the old processes still work

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the [feature] editor Anything related to the editor. label Dec 21, 2024
@charliescheer charliescheer added this to the Future milestone Dec 21, 2024
@charliescheer charliescheer self-assigned this Dec 21, 2024
@charliescheer charliescheer changed the base branch from trunk to charlie/textkit-2-round2-mk1 December 21, 2024 23:11
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 21, 2024

Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1691-2fde51e-01940a9f-3f41-4d09-b70c-48fad2d203b3
Version4.55
Bundle IDcom.codality.NotationalFlow.Alpha
Commit2fde51e
App Center BuildSimplenote - Installable Builds #423
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@charliescheer charliescheer force-pushed the charlie/textkit-2-round2-mk2 branch from a7c8b23 to 4175376 Compare December 26, 2024 20:53
Base automatically changed from charlie/textkit-2-round2-mk1 to feature/text-kit-2 December 26, 2024 22:44
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers, just one comment on the way the Storage is init'ed.

Feel free to :shipit: when ready!

Simplenote/SPTextView.swift Outdated Show resolved Hide resolved
@charliescheer charliescheer merged commit 5ad6503 into feature/text-kit-2 Dec 28, 2024
5 of 9 checks passed
@charliescheer charliescheer deleted the charlie/textkit-2-round2-mk2 branch December 28, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] editor Anything related to the editor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants