-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textkit 2: Fixed gesture recognizer so tapping into text does not fallback to text kit 1 #1691
Merged
charliescheer
merged 6 commits into
feature/text-kit-2
from
charlie/textkit-2-round2-mk2
Dec 28, 2024
Merged
Textkit 2: Fixed gesture recognizer so tapping into text does not fallback to text kit 1 #1691
charliescheer
merged 6 commits into
feature/text-kit-2
from
charlie/textkit-2-round2-mk2
Dec 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliescheer
changed the base branch from
trunk
to
charlie/textkit-2-round2-mk1
December 21, 2024 23:11
📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 Danger |
4 tasks
charliescheer
force-pushed
the
charlie/textkit-2-round2-mk2
branch
from
December 26, 2024 20:53
a7c8b23
to
4175376
Compare
Base automatically changed from
charlie/textkit-2-round2-mk1
to
feature/text-kit-2
December 26, 2024 22:44
jleandroperez
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers, just one comment on the way the Storage is init'ed.
Feel free to when ready!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In my previous PR with TextKit 2, #1690 , I added the basic setup for SPTextView to use Text Kit 2 if available, and I created a mechanism to fallback to text kit 1 without losing all formatting. However in that PR if you did anything other than view a note you were immediately dropped back into Text Kit 1.
In this PR I have updated gesture recognizer to not use
layoutManager
so the view does not drop back to text kit 1. This should allow you to tap into, interact with, edit, and save text while still in text kit 2.Next up: Search
Test
is switching to TextKit 1 compatibility mode because its layoutManager was accessed
in the consoleReview
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txt
if the changes should be included in release notes. Include details about updating the notes in this section. For example: