Classify URL collection scripts - #816
Merged
Merged
Conversation
Use a frozen static artifact policy by default, while preserving an explicit full-retention compatibility option.\n\nAI assistance: OpenAI gpt-5.6-sol via OpenCode implemented and tested this change. Chris Huber remains responsible for every line.
AI assistance: OpenAI gpt-5.6-terra via OpenCode was used to apply and verify scoped WordPress formatting and static-analysis cleanup. Chris Huber reviewed the change.
Collaborator
Author
Follow-up verification\n\nCommit
|
Collaborator
Author
CI Completion\n\nThe replacement Test workflow passed on commit
|
Reconcile shared plans, retry pacing, and bounded concurrent collection with deterministic script exclusion provenance and explicit full-retention compatibility. AI assistance: OpenAI gpt-5.6-terra via OpenCode reconciled and verified this merge. Chris Huber remains responsible for every line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #813
Summary
include_scripts=trueand CLI--retain-scriptsfor full legacy retention;include_scripts=falseremains explicit complete omission.Evidence
The deterministic Wix-like fixture contains two external application assets (4,000 and 6,000 bytes), an inline hydration candidate, and a data script. Static collection makes 2 asset requests rather than 4 and reduces retained bytes by more than 10,000 while preserving the server-rendered heading, body, stylesheet, and image references. The resulting artifact compiles with
dynamic_client_assets.status=provenand no site-plan diagnostics.Verification
php tests/smoke-url-site-collector.phpphp tests/smoke-url-batch-import.phpphp tests/smoke-url-import-runtime.phpnpm test -- --all(44 passed, 0 failed; 10 environment-gated tests skipped)composer validate --strictnpm run test:inventoryphp -l includes/class-static-site-importer-url-site-collector.phpphp -l static-site-importer.phpphp -l tests/smoke-url-site-collector.phpgit diff --checkCompatibility
Existing callers that explicitly select
include_scripts=trueretain the prior full-fetch/full-markup behavior. The default intentionally changes to static retention. WordPress runtime and browser tests were not run because this worktree is not the installed Studio plugin and the shell has no standalonewpbinary.AI Assistance
OpenAI gpt-5.6-sol via OpenCode implemented and tested this change. Chris Huber remains responsible for every line.