Fix fixture matrix empty-root planning - #838
Merged
Merged
Conversation
AI assistance: OpenAI GPT-5.6 Sol via OpenCode restored invalid-root planning semantics and added focused regression coverage. Chris Huber reviewed and owns this change.
AI assistance: OpenAI GPT-5.6 Sol via OpenCode aligned fixture-matrix assertions with the current execution contract and ran focused verification. Chris Huber reviewed and owns this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planning_emptyfor missing, non-directory, and top-level symlink fixture roots before discoveryrequires a complete eligible fixture inventoryexecution errorEvidence
composer install --no-interaction --prefer-disthydrated the PHP dependencies.node --test tools/fixture-matrix.test.mjs: 255 passed, 0 failed.node --test --test-name-pattern="fixture selection fails closed|top-level symlink fixture roots|missing and top-level symlink roots" tools/fixture-matrix.test.mjs: 3 passed, 0 failed.node --check lib/fixture-matrix/fixtures.mjs && node --check lib/fixture-matrix/result.mjs && node --check tools/run-fixture-matrix.mjs && node --check bench/static-site-fixture-matrix.bench.mjs && node --check tools/fixture-matrix.test.mjsgit diff --check origin/main...HEADnpm testrunner has an unrelated timing-sensitive failure in the existing runner-progress test attools/fixture-matrix.test.mjs:5134when it executes its Node suite alongside the manifest; the same full file passes standalone as above.Compatibility
Refs #833
Follow-up to #834
AI Assistance
OpenAI GPT-5.6 Sol via OpenCode rebased/cherry-picked the isolated fix, aligned the stale assertions, hydrated dependencies, ran focused/full Node and PHP-equivalent validation, and drafted this PR update. Chris Huber reviewed and owns every line.