Clean up e2e tests #2168
Open
Clean up e2e tests #2168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
commented
Dec 2, 2025
| }; | ||
| } | ||
|
|
||
| async closeWhatsNew() { |
Contributor
Author
There was a problem hiding this comment.
Moved closeWhatsNew to onboarding to avoid duplications and keep consistency
nightnei
commented
Dec 2, 2025
| return this.locator.getByRole( 'button', { name: 'Close' } ); | ||
| } | ||
|
|
||
| async close() { |
nightnei
commented
Dec 2, 2025
| await expect( dialog.locator ).toBeVisible(); | ||
| return dialog; | ||
| if ( ! isButtonVisible ) { | ||
| throw new Error( 'Add Site button not found on the main sidebar' ); |
Contributor
Author
There was a problem hiding this comment.
I think it's better to keep this function more specific, since if it's not available in UI then we can mute an error
Also, with the current use case - there is no such thing as "sidebar" inside onboarding, so it's a bit misleading to create MainSidebar and running openAddSiteModal, instead of directly running new AddSiteModal.
Contributor
📊 Performance Test ResultsComparing c9ed3d0 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
See comments in the PR below
Testing Instructions
PR's build should be green