Skip to content

Conversation

@katinthehatsite
Copy link
Contributor

Related issues

Fixes:

Proposed Changes

This PR addresses misc comments from #2271 that were submitted after the PR was merged.

Testing Instructions

  • Pull the changes from this branch
  • Apply the following diff:
index 31db0fc9..b538c66b 100644
--- a/src/stores/sync/sync-hooks.ts
+++ b/src/stores/sync/sync-hooks.ts
@@ -83,6 +83,9 @@ export function useLocalFileTree() {
                        setIsLoading( true );
                        setError( null );
                        try {
+                               // TEMPORARY: Simulate error for testing
+                               throw new Error( 'Simulated error for testing error handling' );
+                               
                                const rawNodes = await getIpcApi().listLocalFileTree( siteId, path, 3 );
                                return convertRawToTreeNodes( rawNodes );
                        } catch ( err ) {
  • Start Studio with npm start
  • Ensure that you have at least one WP.com site connected to Studio
  • Navigate to the Sync tab
  • Click on Push
  • Select Specific files and folders option
  • Confirm that when you open wp-content, you see the error shown on the screenshot above

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite marked this pull request as ready for review January 5, 2026 15:09
@katinthehatsite katinthehatsite requested a review from sejas January 5, 2026 15:09
Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Image

@katinthehatsite
Copy link
Contributor Author

Thanks for the review @gavande1 ❤️

@katinthehatsite katinthehatsite merged commit 863d505 into trunk Jan 6, 2026
7 checks passed
@katinthehatsite katinthehatsite deleted the fix/address-comments-on-2271 branch January 6, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants