Agentic UI: Close the create-site flow on Escape - #4453
Merged
Conversation
sejas
marked this pull request as ready for review
August 12, 2026 15:18
Collaborator
📊 Performance Test ResultsComparing 3973305 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
katinthehatsite
approved these changes
Aug 13, 2026
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
This looks good and works as expected 👍
Nice improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI-assisted editing helped draft the Escape-handling tests; the behavior, guards, and final code were reviewed and verified manually.
Proposed Changes
Pressing Escape now closes the create-site onboarding flow, matching how the fullscreen Settings overlay already behaves. Guards keep it from firing when it shouldn't:
defaultPrevented), so Escape closes the popover instead of the whole flow.Also aligns the Settings overlay's close icon with the onboarding one: the settings view portals outside the classic-density container, so its close icon rendered oversized; it now matches at 16px, and a redundant 32px override in the fullscreen chrome is removed.
Testing Instructions
npm start(or serve the agentic UI vianpm run cli:build:ui && node apps/cli/dist/cli/main.mjs ui --no-open).Pre-merge Checklist
npm test) — 4 new Escape cases inlayout-onboarding