Drop Blueprint features the native runner cannot accept - #4488
Merged
gavande1 merged 4 commits intoAug 13, 2026
Conversation
1 task
blueprints.phar's v1 schema knows only features.networking, so a Blueprint setting features.intl fails validation outright rather than having the flag ignored. Stylish Press and other gallery Blueprints set it, which is why creating a site from them failed under the native PHP runtime. Both intl and preferredVersions are environment choices the runner does not make here: Studio picks the PHP binary and installs WordPress before the Blueprint runs. normalizeBlueprintForRunner now strips both, extending the preferredVersions handling that was already inline. Studio's PHP builds ship the Intl extension, so dropping the flag loses nothing.
gavande1
force-pushed
the
fix/stu-2124-strip-unsupported-blueprint-features
branch
from
August 10, 2026 08:33
c82efad to
63878eb
Compare
Collaborator
📊 Performance Test ResultsComparing 0f7855b vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
…nsupported-blueprint-features # Conflicts: # apps/cli/lib/native-php/blueprints.ts # apps/cli/lib/native-php/tests/blueprints.test.ts
sejas
approved these changes
Aug 12, 2026
sejas
left a comment
Member
There was a problem hiding this comment.
Thanks I tested it by creating a new site using the Stylish Press blueprint and worked as expected.
I think it makes sense to remove the networking feature because native php runtime have already network access.
Thanks for centralizing the blueprint customization in a single function.
networking.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI assisted with reproducing the failure, tracing it to the schema mismatch between Playground's JS schema and the one bundled in blueprints.phar, and drafting the fix and tests. I reviewed the change and verified it locally against the Stylish Press Blueprint.
Proposed Changes
Creating a site from the Stylish Press Blueprint failed under the native PHP runtime. The cause is a schema mismatch, not a parsing failure.
Studio pre-validates a Blueprint with Playground's JS schema, then hands it to
blueprints.phar, which validates it again against its own v1 schema. That schema accepts onlyfeatures.networking, so a Blueprint settingfeatures.intlis rejected outright rather than having the flag ignored:intlandpreferredVersionsare both environment choices the runner does not make here. Studio picks the PHP binary and installs WordPress before the Blueprint runs.normalizeBlueprintForRunnernow strips both, extending thepreferredVersionshandling that was already inline. Studio's PHP builds ship the Intl extension, so dropping the flag loses nothing.Testing Instructions
npm run cli:build.Failed to apply Blueprint. Create a site from the Blueprint under the native runtime:0and printsSite created successfully.features.networkingstill reaches the runner, and a Blueprint with nofeatureskey is unchanged. Both are covered by the unit tests below.Tests:
npm test -- apps/cli/lib/native-php/tests/blueprints.test.ts→ all 5 pass.Reset (to re-test):
Pre-merge Checklist