Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Global styles: allow override to work when Gutenberg plugin is active #8638

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented Jan 28, 2025

Fixes #8636

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Blockbase.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@merkushin
Copy link
Member

merkushin commented Jan 28, 2025

@pkevan is it ready for testing and review?
Are there any testing instructions?

@pkevan
Copy link
Contributor Author

pkevan commented Jan 29, 2025

@pkevan is it ready for testing and review?

Yes, it can be ready - I was going to attempt to see some numbers on how many users might be affected by fixing this, since they could be currently using the inherited color palettes.

Are there any testing instructions?

It can be tested with any child theme of blockbase on an environment where Gutenberg plugin is activated - with the patch applied and the theme.json of the child theme updated to include "optOutOfParentStyleVariations": "true", in the custom section.

@merkushin
Copy link
Member

@pkevan

Perhaps a silly question: how can I use it in my sandbox (a different repo is used there)?
Meanwhile, I'm looking for an answer in docs.

@pkevan
Copy link
Contributor Author

pkevan commented Jan 30, 2025

@pkevan

Perhaps a silly question: how can I use it in my sandbox (a different repo is used there)? Meanwhile, I'm looking for an answer in docs.

No such thing as a silly question 😄

Locally, the requests to the variations REST API endpoint on the same domain, but when testing via a Simple site, you would need to sandbox requests to public-api also.

@MaggieCabrera
Copy link
Contributor

I applied this change to my sandbox and tested Jackson and I still see the variations from Blockbase. Do we need to do anything else to test this?

We will be archiving this repo soon (TM) in favor of the enterprise repo and I was trying to get this merged but it seems it's not there yet, or I'm missing out how to test it!

@pkevan
Copy link
Contributor Author

pkevan commented Jan 31, 2025

I applied this change to my sandbox and tested Jackson and I still see the variations from Blockbase. Do we need to do anything else to test this?

Strange - did you sandbox public-api also?

It works as expected when I change to the Jackson theme when sandboxed for me.

Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my public api not being sandboxed on FF :D this works as intended

@pkevan
Copy link
Contributor Author

pkevan commented Feb 3, 2025

Thanks @MaggieCabrera!

@pkevan pkevan merged commit 54d7734 into trunk Feb 3, 2025
2 checks passed
@pkevan pkevan deleted the fix/issue-8636 branch February 3, 2025 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockbase: style variation opt-out not always working
3 participants