-
Notifications
You must be signed in to change notification settings - Fork 363
Global styles: allow override to work when Gutenberg plugin is active #8638
Conversation
Preview changesI've detected changes to the following themes in this PR: Blockbase. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
@pkevan is it ready for testing and review? |
Yes, it can be ready - I was going to attempt to see some numbers on how many users might be affected by fixing this, since they could be currently using the inherited color palettes.
It can be tested with any child theme of |
Perhaps a silly question: how can I use it in my sandbox (a different repo is used there)? |
No such thing as a silly question 😄 Locally, the requests to the |
I applied this change to my sandbox and tested Jackson and I still see the variations from Blockbase. Do we need to do anything else to test this? We will be archiving this repo soon (TM) in favor of the enterprise repo and I was trying to get this merged but it seems it's not there yet, or I'm missing out how to test it! |
Strange - did you sandbox public-api also? It works as expected when I change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my public api not being sandboxed on FF :D this works as intended
Thanks @MaggieCabrera! |
Fixes #8636