Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Kiosko: Add changelog.txt for woocommerce.com #8642

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

iamtakashi
Copy link
Contributor

@iamtakashi iamtakashi commented Jan 28, 2025

Context: p9h1Lv-feI-p2

@mikachan @dsas Do you think adding a changelog.txt to this theme will cause any issues in Dotcom? I don't think we should add it to all the themes as it's redundant because a change log lives in the readme.txt, but currently, this is the only theme that needs the file.

We might need to update the scripts/workflow that updates the readme.txt so that it updates changelog.txt too if it exists.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Kiosko.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@dsas
Copy link
Contributor

dsas commented Jan 29, 2025

It shouldn't cause any issues.

It's a bit of an annoying requirement. Given it's just kiosko (so far) does it make sense to just continue to manage this by hand for now rather than automating it? I'm not sure how/if changelog generation might change in the brave new one-repo world.

@iamtakashi
Copy link
Contributor Author

Given it's just kiosko (so far) does it make sense to just continue to manage this by hand for now rather than automating it?

Yeah, let's continue editing this by hand for now. I doubt Kiosko gets many updates. But I wonder how best to remind us to update the changelog.txt.

How about adding this in the changelog in the readme.txt? I am hoping to see it :)

[We must also update the changelog.txt ](https://github.com/Automattic/themes/tree/trunk/kiosko/changelog.txt)

@MaggieCabrera
Copy link
Contributor

I'm bringing this in, let's open an issue on the other repo about this to potentially add a script that automates this step, it shouldn't be terribly hard, more a matter to scrape some time to do it

@MaggieCabrera MaggieCabrera merged commit f2ecaf5 into trunk Jan 31, 2025
2 checks passed
@MaggieCabrera MaggieCabrera deleted the add/kiosko-changelog branch January 31, 2025 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants