-
Notifications
You must be signed in to change notification settings - Fork 104
Streamwrapper: Move logic out into the open #4595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
f336520
to
cc267ae
Compare
cc267ae
to
3daa544
Compare
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4595 +/- ##
==========================================
Coverage 31.38% 31.38%
Complexity 5034 5034
==========================================
Files 299 299
Lines 22065 22065
==========================================
Hits 6926 6926
Misses 15139 15139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This flips the logic and may result in breakage in Local Dev Env which didn't have the stream wrapper constant. This is being addressed here: Automattic/vip-container-images#517 But even when that's merged we don't update wp-config for existing environments. |
2260228
to
3824c48
Compare
3824c48
to
b3f40a9
Compare
|
Description
Similar to #4589, we should move this logic out into the open since it is already enabled for everyone. There is still the option to disable it with the constant
VIP_FILESYSTEM_USE_STREAM_WRAPPER
though.