Skip to content

Improve/ignore platform required paths in new relic #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mchanDev
Copy link
Contributor

@mchanDev mchanDev commented May 4, 2025

Description

By default, New Relic runs for every request, including internal metrics endpoints which get hit often. Unfortunately, this has a negative impact on the accuracy because these internal endpoints are very fast, leading to skewing of stats like avg response time.

Changelog Description

Added

  • Added newrelic_ignore_transaction to some internal endpoints that should not be tracked in New Relic to ensure accuracy of the app stats.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@mchanDev mchanDev requested a review from a team as a code owner May 4, 2025 23:56
walthowd
walthowd previously approved these changes May 4, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.67%. Comparing base (b7ea99e) to head (1f3d54c).

Files with missing lines Patch % Lines
prometheus/endpoint.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6279      +/-   ##
=============================================
+ Coverage      31.32%   31.67%   +0.34%     
  Complexity      5035     5035              
=============================================
  Files            299      299              
  Lines          22119    22121       +2     
=============================================
+ Hits            6929     7007      +78     
+ Misses         15190    15114      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mchanDev mchanDev force-pushed the improve/ignore-platform-required-paths-in-new-relic branch 3 times, most recently from 6b546b9 to b9b9a8c Compare May 5, 2025 00:41
sjinks
sjinks previously approved these changes May 5, 2025
Copy link
Member

@sjinks sjinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like a second option from @rinatkhaziev

Copy link
Contributor

@rinatkhaziev rinatkhaziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, unfortunately as-is is not going to work, I left inline feedback.

@rinatkhaziev rinatkhaziev dismissed stale reviews from sjinks and walthowd May 5, 2025 15:38

needs updates.

@mchanDev
Copy link
Contributor Author

mchanDev commented May 5, 2025

As per feedback from @rinatkhaziev
The PR has had the newrelic_ignore_transaction moved as noted in the PR comments

And an additional PR opened against the nginx-http-concat repo
Automattic/nginx-http-concat#84

Copy link
Contributor

@rinatkhaziev rinatkhaziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Copy link

sonarqubecloud bot commented May 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants