-
Notifications
You must be signed in to change notification settings - Fork 104
Improve/ignore platform required paths in new relic #6279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Improve/ignore platform required paths in new relic #6279
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6279 +/- ##
=============================================
+ Coverage 31.32% 31.67% +0.34%
Complexity 5035 5035
=============================================
Files 299 299
Lines 22119 22121 +2
=============================================
+ Hits 6929 7007 +78
+ Misses 15190 15114 -76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6b546b9
to
b9b9a8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would like a second option from @rinatkhaziev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, unfortunately as-is is not going to work, I left inline feedback.
b9b9a8c
to
faf066e
Compare
As per feedback from @rinatkhaziev And an additional PR opened against the nginx-http-concat repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
|
Description
By default, New Relic runs for every request, including internal metrics endpoints which get hit often. Unfortunately, this has a negative impact on the accuracy because these internal endpoints are very fast, leading to skewing of stats like avg response time.
Changelog Description
Added
newrelic_ignore_transaction
to some internal endpoints that should not be tracked in New Relic to ensure accuracy of the app stats.Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test