Skip to content

Conversation

@ingeniumed
Copy link
Contributor

Description

Add a check for the WP/PHP/GB versions when trying to load the RTC integration. The GB version targets 21.7, just to be safe for now. It could be raised to 21.9 but I'd rather bump it up after 2 weeks when the final rebase we have done rolls out in Automattic/vip-go-mu-plugins-ext#94.

Changelog Description

Changed

  • VIP Real-time collaboration: Added a check to verify the PHP/WP/GB version before loading the integration.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • [x ] This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

  1. Check out PR.
  2. Enable the VIP RTC integration
  3. Change your PHP/WP version and see it failing to load
  4. Change your GB version (easiest way is to tweak the Gutenberg.php file) and see it failing to load

I've kept it draft just to get some feedback on if there's a better approach I could go for here? We do have these checks in the plugin itself, so is there a benefit in adding it here as well?

@ingeniumed ingeniumed self-assigned this Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.70%. Comparing base (0728086) to head (daf1024).

Files with missing lines Patch % Lines
integrations/real-time-collaboration.php 27.27% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6600      +/-   ##
=============================================
- Coverage      34.80%   34.70%   -0.10%     
- Complexity      5028     5035       +7     
=============================================
  Files            294      294              
  Lines          20709    20719      +10     
=============================================
- Hits            7207     7190      -17     
- Misses         13502    13529      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants