-
Notifications
You must be signed in to change notification settings - Fork 107
Remove Varnish support and implement class-based purges #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6642 +/- ##
=============================================
- Coverage 34.84% 34.59% -0.25%
- Complexity 5029 5073 +44
=============================================
Files 295 295
Lines 20746 20940 +194
=============================================
+ Hits 7228 7244 +16
- Misses 13518 13696 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot generate public facing documentation update. |
|
@rinatkhaziev I've opened a new pull request, #6645, to work on those changes. Once the pull request is ready, I'll request review from you. |
wp-cli/vip-cache.php
Outdated
| } | ||
|
|
||
| if ( 'site' === $scope && ! isset( $assoc_args['skip-confirm'] ) ) { | ||
| WP_CLI::confirm( "⚠️ You're about to invalidate Page Cache for the whole site, this can severely impact performance and stability for large sites. Are you sure?" ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we maybe also change this line to be:
WP_CLI::confirm(
sprintf(
"⚠️ You're about to invalidate Page Cache for (%s). This can severely impact performance and stability for large sites. Are you sure?",
trailingslashit( home_url() )
)
);Since it's still scoped by site, this will be useful to know which site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion Wes
|


Description
This pull request introduces several improvements and new features to the VIP Cache Manager, focusing on expanding cache purge capabilities, enhancing the CLI and dashboard interfaces, and improving test coverage and maintainability. The key changes include adding new purge functions for different cache scopes, updating the CLI to support these scopes, modernizing the API with deprecation notices for old functions, and strengthening the test suite.
API and Functionality Enhancements:
vip-cache-manager/api.phpfor purging specific cache scopes (site, origin, uploads, static files, private files), and marked the oldwpcom_vip_*functions as deprecated in favor of the newwpvip_*versions. [1] [2] [3]CLI Improvements:
wp-cli/vip-cache.phpto support a--scopeoption, allowing users to target specific cache scopes (site, origin, uploads, static, private) for purging. Added input validation and improved confirmation messaging.Dashboard UI:
vip-cache-manager/js/dashboard-widget.js) to enhance the dashboard widget, supporting dynamic UI updates and confirmation prompts for different purge actions.Testing and Internal Maintenance:
tests/test-vip-cache-manager.phpto cover new special purge actions, added a data provider for these, and improved test isolation by resetting cache manager state insetUpandtearDown. [1] [2] [3]Changelog Description
Added
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test