Skip to content

Commit

Permalink
change to use sentence cases for "Sales Channel" and "Online Store"
Browse files Browse the repository at this point in the history 
+ update snapshots
  • Loading branch information
@htdat
htdat committed Feb 27, 2025
1 parent 2fb5c45 commit 8d9f428
Show file tree
Hide file tree
Showing 12 changed files with 72 additions and 73 deletions.
4 changes: 2 additions & 2 deletions client/payment-details/order-details/test/__snapshots__/index.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,13 @@ exports[`Order details page should match the snapshot - Charge without payment i
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down
2 changes: 1 addition & 1 deletion client/payment-details/summary/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ const composePaymentSummaryItems = ( {
: '–',
},
{
title: __( 'Sales Channel', 'woocommerce-payments' ),
title: __( 'Sales channel', 'woocommerce-payments' ),
content: (
<span>
{ isTapToPay( metadata?.reader_model )
Expand Down
46 changes: 23 additions & 23 deletions client/payment-details/summary/test/__snapshots__/index.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,13 @@ exports[`PaymentDetailsSummary capture notification and fraud buttons renders ca
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -508,13 +508,13 @@ exports[`PaymentDetailsSummary capture notification and fraud buttons renders th
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -868,13 +868,13 @@ exports[`PaymentDetailsSummary correctly renders a charge 1`] = `
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -1179,13 +1179,13 @@ exports[`PaymentDetailsSummary correctly renders when payment intent is missing
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -1504,13 +1504,13 @@ exports[`PaymentDetailsSummary order missing notice does not render notice if or
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -1829,13 +1829,13 @@ exports[`PaymentDetailsSummary order missing notice renders notice if order miss
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -2177,13 +2177,13 @@ exports[`PaymentDetailsSummary renders a charge with subscriptions 1`] = `
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -2506,13 +2506,13 @@ exports[`PaymentDetailsSummary renders fully refunded information for a charge 1
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -2774,13 +2774,13 @@ exports[`PaymentDetailsSummary renders loading state 1`] = `
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -3078,13 +3078,13 @@ exports[`PaymentDetailsSummary renders partially refunded information for a char
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down Expand Up @@ -3403,7 +3403,7 @@ exports[`PaymentDetailsSummary renders the Tap to Pay channel from metadata 1`]
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
Expand Down Expand Up @@ -3728,13 +3728,13 @@ exports[`PaymentDetailsSummary renders the information of a dispute-reversal cha
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down
4 changes: 2 additions & 2 deletions client/payment-details/test/__snapshots__/index.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -656,13 +656,13 @@ exports[`Payment details page should match the snapshot - Payment Intent query p
<span
class="woocommerce-list__item-title"
>
Sales Channel
Sales channel
</span>
<span
class="woocommerce-list__item-content"
>
<span>
Online Store
Online store
</span>
</span>
</div>
Expand Down
11 changes: 5 additions & 6 deletions client/transactions/filters/config.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ export const getAdvancedFilters = (
},
channel: {
labels: {
add: __( 'Sales Channel', 'woocommerce-payments' ),
add: __( 'Sales channel', 'woocommerce-payments' ),
remove: __(
'Remove transaction sales channel filter',
'woocommerce-payments'
Expand All @@ -451,15 +451,14 @@ export const getAdvancedFilters = (
'Select a transaction sales channel filter match',
'woocommerce-payments'
),
/* translators: A sentence describing a Transaction Sales Channel filter. */
title:
wooCommerceVersion < 7.8
? __(
'{{title}}Sales Channel{{/title}} {{rule /}} {{filter /}}',
'{{title}}Sales channel{{/title}} {{rule /}} {{filter /}}',
'woocommerce-payments'
)
: __(
'<title>Sales Channel</title> <rule /> <filter />',
'<title>Sales channel</title> <rule /> <filter />',
'woocommerce-payments'
),
filter: __(
Expand All @@ -473,7 +472,7 @@ export const getAdvancedFilters = (
/* translators: Sentence fragment, logical, "Is" refers to searching for transactions matching a chosen transaction sales channel type. */
label: _x(
'Is',
'Sales Channel',
'Sales channel',
'woocommerce-payments'
),
},
Expand All @@ -482,7 +481,7 @@ export const getAdvancedFilters = (
/* translators: Sentence fragment, logical, "Is not" refers to searching for transactions that don\'t match a chosen transaction sales channel type. */
label: _x(
'Is not',
'Sales Channel',
'Sales channel',
'woocommerce-payments'
),
},
Expand Down
2 changes: 1 addition & 1 deletion client/transactions/filters/test/__snapshots__/index.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ HTMLOptionsCollection [
<option
value="online"
>
Online Store
Online store
</option>,
<option
value="in_person"
Expand Down
2 changes: 1 addition & 1 deletion client/transactions/filters/test/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ describe( 'Transactions filters', () => {
let ruleSelector: HTMLElement;

beforeEach( () => {
addAdvancedFilter( 'Sales Channel' );
addAdvancedFilter( 'Sales channel' );
ruleSelector = screen.getByRole( 'combobox', {
name: /transaction sales channel filter/i,
} );
Expand Down
4 changes: 2 additions & 2 deletions client/transactions/list/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ const getColumns = (
},
{
key: 'channel',
label: __( 'Sales Channel', 'woocommerce-payments' ),
screenReaderLabel: __( 'Sales Channel', 'woocommerce-payments' ),
label: __( 'Sales channel', 'woocommerce-payments' ),
screenReaderLabel: __( 'Sales channel', 'woocommerce-payments' ),
required: true,
isLeftAligned: true,
},
Expand Down
Loading

0 comments on commit 8d9f428

Please sign in to comment.