chore: remove unnecessary useEffect on settings toggle (#10449)

Automattic · Feb 26, 2025 · 9574dc5 · 9574dc5
1 parent c5ef672
commit 9574dc5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 18 deletions.
diff --git a/changelog/chore-remove-unneeded-useeffect-in-settings b/changelog/chore-remove-unneeded-useeffect-in-settings
@@ -0,0 +1,5 @@
+Significance: patch
+Type: dev
+Comment: chore: remove unnecessary useEffect on settings toggle
+
+
diff --git a/client/settings/advanced-settings/multi-currency-toggle.js b/client/settings/advanced-settings/multi-currency-toggle.js
@@ -3,7 +3,6 @@
  */
 import { CheckboxControl, ExternalLink } from '@wordpress/components';
 import { __ } from '@wordpress/i18n';
-import { useEffect, useRef } from '@wordpress/element';
 
 /**
  * Internal dependencies
@@ -17,14 +16,6 @@ const MultiCurrencyToggle = () => {
 		updateIsMultiCurrencyEnabled,
 	] = useMultiCurrency();
 
-	const headingRef = useRef( null );
-
-	useEffect( () => {
-		if ( ! headingRef.current ) return;
-
-		headingRef.current.focus();
-	}, [] );
-
 	const handleMultiCurrencyStatusChange = ( value ) => {
 		updateIsMultiCurrencyEnabled( value );
 	};

diff --git a/client/settings/advanced-settings/wcpay-subscriptions-toggle.js b/client/settings/advanced-settings/wcpay-subscriptions-toggle.js
@@ -3,7 +3,6 @@
  */
 import { CheckboxControl, ExternalLink } from '@wordpress/components';
 import { __, sprintf } from '@wordpress/i18n';
-import { useEffect, useRef } from '@wordpress/element';
 
 /**
  * Internal dependencies
@@ -18,14 +17,6 @@ const WCPaySubscriptionsToggle = () => {
 		updateIsWCPaySubscriptionsEnabled,
 	] = useWCPaySubscriptions();
 
-	const headingRef = useRef( null );
-
-	useEffect( () => {
-		if ( ! headingRef.current ) return;
-
-		headingRef.current.focus();
-	}, [] );
-
 	const handleWCPaySubscriptionsStatusChange = ( value ) => {
 		updateIsWCPaySubscriptionsEnabled( value );
 	};