chore: remove unused arguments from usePaymentCompleteHandler

Automattic · Feb 28, 2025 · a2c68da · a2c68da
1 parent ec98a59
commit a2c68da
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 15 deletions.
diff --git a/changelog/chore-usePaymentCompleteHandler-unused-arguments b/changelog/chore-usePaymentCompleteHandler-unused-arguments
@@ -0,0 +1,5 @@
+Significance: patch
+Type: dev
+Comment: chore: remove unused arguments from usePaymentCompleteHandler
+
+
diff --git a/client/checkout/blocks/hooks.js b/client/checkout/blocks/hooks.js
@@ -14,8 +14,6 @@ import {
 
 export const usePaymentCompleteHandler = (
 	api,
-	stripe,
-	elements,
 	onCheckoutSuccess,
 	emitResponse,
 	shouldSavePayment
@@ -33,7 +31,7 @@ export const usePaymentCompleteHandler = (
 			),
 		// not sure if we need to disable this, but kept it as-is to ensure nothing breaks. Please consider passing all the deps.
 		// eslint-disable-next-line react-hooks/exhaustive-deps
-		[ elements, stripe, api, shouldSavePayment ]
+		[ api, shouldSavePayment ]
 	);
 };
 

diff --git a/client/checkout/blocks/payment-processor.js b/client/checkout/blocks/payment-processor.js
@@ -1,11 +1,7 @@
 /**
  * External dependencies
  */
-import {
-	PaymentElement,
-	useElements,
-	useStripe,
-} from '@stripe/react-stripe-js';
+import { PaymentElement, useElements } from '@stripe/react-stripe-js';
 import {
 	getPaymentMethods,
 	// eslint-disable-next-line import/no-unresolved
@@ -70,7 +66,6 @@ const PaymentProcessor = ( {
 	onLoadError = noop,
 	theme,
 } ) => {
-	const stripe = useStripe();
 	const elements = useElements();
 	const hasLoadErrorRef = useRef( false );
 	const linkCleanupRef = useRef( null );
@@ -269,8 +264,6 @@ const PaymentProcessor = ( {
 
 	usePaymentCompleteHandler(
 		api,
-		stripe,
-		elements,
 		onCheckoutSuccess,
 		emitResponse,
 		shouldSavePayment

diff --git a/client/checkout/blocks/saved-token-handler.js b/client/checkout/blocks/saved-token-handler.js
@@ -8,8 +8,6 @@ import { removeLinkButton } from '../stripe-link';
 
 export const SavedTokenHandler = ( {
 	api,
-	stripe,
-	elements,
 	eventRegistration: { onPaymentSetup, onCheckoutSuccess },
 	emitResponse,
 } ) => {
@@ -38,8 +36,6 @@ export const SavedTokenHandler = ( {
 	// Once the server has completed payment processing, confirm the intent of necessary.
 	usePaymentCompleteHandler(
 		api,
-		stripe,
-		elements,
 		onCheckoutSuccess,
 		emitResponse,
 		false // No need to save a payment that has already been saved.