Add E2E tests to ensure non-admin users can log to wp-admin with no e…

…rrors (#10374)

Co-authored-by: Eduardo Umpierre <[email protected]>

changelog/dev-5101-add-e2e-test-non-admin-users-can-login-to-wp-admin

@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+Add new E2E tests to make sure a non-admin user, such as an editor, can access the wp-admin without errors.

tests/e2e/config/default.ts

@@ -18,6 +18,11 @@ export const config = {
 		guest: {
 			email: '[email protected]',
 		},
+		editor: {
+			username: 'editor',
+			password: 'password',
+			email: '[email protected]',
+		},
 	},
 	products: {
 		cap: {

tests/e2e/config/users.json

@@ -0,0 +1,27 @@
+{
+  "users": {
+    "admin": {
+      "username": "admin",
+      "password": "password",
+      "email": "[email protected]"
+    },
+    "customer": {
+      "username": "customer",
+      "password": "password",
+      "email": "[email protected]"
+    },
+    "subscriptions-customer": {
+      "username": "subscriptions-customer",
+      "password": "password",
+      "email": "[email protected]"
+    },
+    "guest": {
+      "email": "[email protected]"
+    },
+    "editor": {
+      "username": "editor",
+      "password": "password",
+      "email": "[email protected]"
+    }
+  }
+}

tests/e2e/env/setup.sh

@@ -36,13 +36,16 @@ handle_permissions() {
 
 # Variables
 BLOG_ID=${E2E_BLOG_ID-111}
-WC_GUEST_EMAIL=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.guest.email')
-WC_CUSTOMER_EMAIL=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.customer.email')
-WC_CUSTOMER_USERNAME=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.customer.username')
-WC_CUSTOMER_PASSWORD=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.customer.password')
-WP_ADMIN=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.admin.username')
-WP_ADMIN_PASSWORD=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.admin.password')
-WP_ADMIN_EMAIL=$(<"$DEFAULT_CONFIG_JSON_PATH" jq -r '.users.admin.email')
+WC_GUEST_EMAIL=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.guest.email')
+WC_CUSTOMER_EMAIL=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.customer.email')
+WC_CUSTOMER_USERNAME=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.customer.username')
+WC_CUSTOMER_PASSWORD=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.customer.password')
+WP_ADMIN=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.admin.username')
+WP_ADMIN_PASSWORD=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.admin.password')
+WP_ADMIN_EMAIL=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.admin.email')
+WP_EDITOR=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.editor.username')
+WP_EDITOR_PASSWORD=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.editor.password')
+WP_EDITOR_EMAIL=$(<"$USERS_CONFIG_JSON_PATH" jq -r '.users.editor.email')
 SITE_TITLE="WooPayments E2E site"
 SITE_URL=$WP_URL
 
@@ -270,6 +273,9 @@ cli wp user delete "$WC_GUEST_EMAIL" --yes
 echo "Adding customer account ..."
 cli wp user create "$WC_CUSTOMER_USERNAME" "$WC_CUSTOMER_EMAIL" --role=customer --user_pass="$WC_CUSTOMER_PASSWORD"
 
+echo "Adding editor account ..."
+cli wp user create "$WP_EDITOR" "$WP_EDITOR_EMAIL" --role=editor --user_pass="$WP_EDITOR_PASSWORD"
+
 # TODO: Build a zip and use it to install plugin to make sure production build is under test.
 if [[ "$WCPAY_USE_BUILD_ARTIFACT" = true ]]; then
 	echo "Creating WooPayments zip file from GitHub artifact..."

tests/e2e/env/shared.sh

@@ -10,7 +10,7 @@ export SERVER_CONTAINER="transact_platform_server_wordpress_e2e"
 export DEV_TOOLS_DIR="wcp-dev-tools-e2e"
 export DEV_TOOLS_PATH="$E2E_ROOT/deps/$DEV_TOOLS_DIR"
 export CLIENT_CONTAINER="wcp_e2e_wordpress"
-export DEFAULT_CONFIG_JSON_PATH="$E2E_ROOT/config/default.json"
+export USERS_CONFIG_JSON_PATH="$E2E_ROOT/config/users.json"
 
 step() {
 	echo