-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert merchant side refund from order screen failures E2E tests to Playwright #10173
Convert merchant side refund from order screen failures E2E tests to Playwright #10173
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this one, Taha. The code looks great. I really like your dialogHandler
solution! Tests are passing. I left two nitpicks but pre-approving otherwise.
|
||
// Sometimes the element is not clickable due to the header getting on the way. This seems to | ||
// only happen in CI for WC 7.7.0 so the workaround is to remove those elements. | ||
const hideElementIfExists = ( sel ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: we can type sel
as a string
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 9ed9c66.
); | ||
|
||
// Click the Refund button | ||
const refundItemsButton = await merchantPage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: 'await' has no effect on the type of this expression.ts(80007)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 9ed9c66.
Fixes #9964
Changes proposed in this Pull Request
This PR adds E2E tests of merchant order screen refund failures to Playwright, and removes the existing one from Puppeteer.
Testing instructions
npm run test:e2e-pw orders-refund-failure
and expect all tests to succeed.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge