-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Playwright Migration: convert Order Manual Capture spec #10180
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling it, the conversion looks good at works as intended in most cases. I left a few suggestions 🙂
tests/e2e-pw/specs/merchant/merchant-orders-manual-capture.spec.ts
Outdated
Show resolved
Hide resolved
tests/e2e-pw/specs/merchant/merchant-orders-manual-capture.spec.ts
Outdated
Show resolved
Hide resolved
tests/e2e-pw/specs/merchant/merchant-orders-manual-capture.spec.ts
Outdated
Show resolved
Hide resolved
tests/e2e-pw/specs/merchant/merchant-orders-manual-capture.spec.ts
Outdated
Show resolved
Hide resolved
tests/e2e-pw/specs/merchant/merchant-orders-manual-capture.spec.ts
Outdated
Show resolved
Hide resolved
tests/e2e-pw/specs/merchant/merchant-orders-manual-capture.spec.ts
Outdated
Show resolved
Hide resolved
… the function is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for solving every comment, everything looks good and works as expected now.
There is a comment to update, but apart from that it's ready, let's 🚢 it!
Fixes #9962
Changes proposed in this Pull Request
saveWooPaymentsSettings
function, it looked for any snackbar on the page, not just the success one.Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.