Fixed possible race condition on the WooPay opt-in #10399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +21 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
mgascam
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
LGTM! Tested with my local environment:
- ✅ Using WooPayments, validation error prevents checkout with the
Securely save my information for 1-click checkout option enabled. Checkout works after phone number is entered. - ✅ Using another gateway, the checkout works
- ✅ Also tried to trigger the error and then switch to a different gateway
senadir
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to p1739870652155429-slack-C022WMN88KG
Changes proposed in this Pull Request
This PR moves the checks for clearing the checkout errors to a
useEffectto prevent a race condition where the error is created after being cleredTesting instructions
I'm not sure how to simulate the bug but make sure it's possible to place the order
Using WooPayments
Securely save my information for 1-click checkoutoptionUsing another payment gateway
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge