-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable tokenized ECE by default - round 2 #10415
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Took me a bit because I didn't realize I have the env with the flag already in place that was disabled, but after figuring this out, both client-side and server-side went through. Thanks!
We're going for it! |
Changes proposed in this Pull Request
Enabling the tokenized ECE by default.
It can be disabled locally via a filter, until we remove the feature flag:
Enabling it for GlobalStep testing. We'll disable the feature flag server-side after the GlobalStep testing while we wait for the SkyVerge patch to be released.
Testing instructions
/wp-json/wc/store/v1/cart/add-item
(for example)/?wc-ajax=wcpay_add_to_cart
(for example) and no longer to the Store APInpm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge