Add Negative feedback modal for 2025 Feedback campaign #10421
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
haszari
reviewed
Feb 25, 2025
| 'WooPayments Disable Survey', | ||
| 'woocommerce-payments' | ||
| ) } | ||
| src="https://automattic.survey.fm/woopayments-feedback-campaign-h1-2025" |
There was a problem hiding this comment.
We'll need to keep track of this survey and manage it alongside the campaign - i.e. it's an external dependency.
Is it possible to build the modal in such a way that if the survey disappears/breaks the modal / experience is not bad?
There was a problem hiding this comment.
I had a brief dive into iframe error handling here, but I couldn't find a reliable way to check if the iframe loaded the survey correctly:
- CORS doesn't allow us to call the URL directly and inspect the response status 200
- CORS doesn't allow us to inspect the content of the frame (e.g. check response status or "Page not found")
- The iframe will think it has loaded successfully, even if it is a "Page not found"
AFAICT Crowdsignal for surveys (text fields) is limited to iframes. The API supports voting and polls only.
There was a problem hiding this comment.
At least if we check from the Crowdsignal end we can hopefully find out if we are generating a bunch of 404 experiences. Either way we can manage this manually.
Jinksi
reviewed
Feb 26, 2025
Jinksi
reviewed
Feb 26, 2025
|
thanks @Jinksi I've updated the styles and the survey to remove some of the padding.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10328
Changes proposed in this Pull Request
Add the
NegativeFeedbackModalas part of #10323This modal should be shown when the Merchant is unhappy with WooPayments. This flow will allow us to capture constructive feedback to help improve the product.
The implementation differs from the design in #10328. Rather than creating the survey and submitting inside WooPayments, the survey is hosted by Crowdsignal which allows feedback to flow into our current internal tools.
The excess whitespace comes from Crowdsignal, inside the
<iframe>. This can be altered by adjusting the CSS on the Survey.Note
This PR has some issues with the height in mobile view.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge