Fixes undefined constant WC_Install::STORE_ID_OPTION error #10432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
FangedParakeet
added
the
size: x-small
timur27
reviewed
Feb 24, 2025
There was a problem hiding this comment.
One thing unrelated to your changes is that I'd like to understand in general is why we're hooking onto order processed add_action( 'woocommerce_checkout_order_processed', [ $this, 'checkout_order_processed' ], 10, 2 ); and tracking checkout_order_placed event from within WooPay tracker class for WooPayments checkout. It doesn't hurt, I just started wondering why the error happens on the checkout even with WooPay disabled.
I will get back with the testing outcome soon.
timur27
reviewed
Feb 24, 2025
Yeah, this surprised me a little bit, but it seems that I'd suspect that this is the case because this tracking, in general, was only added with the advent of WooPay for the purposes of specifically tracking WooPay events and consequently this misleading class name has stuck. I think there could be value in giving this class a more meaningful name in the future, but I'd also like to learn a bit more context about why it is named so deceptively in the first place. |
timur27
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
The change makes sense. I've tested locally with WC 7.7.0
develop
- saving settings fails
- checkouts fail
This branch
- saving settings works
- checkouts work
Thanks @FangedParakeet !
mgascam
pushed a commit
that referenced
this pull request
Feb 24, 2025
mgascam
pushed a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Fixes undefined constant WC_Install::STORE_ID_OPTION error
This PR fixes the below error due to incorrect usage of the
definedfunction in a conditional, prior to including this constant in the body of aWooPay_Trackerevent.\WC_Install::STORE_ID_OPTIONwas introduced in WC 8.4, so we must check that this constant is defined for earlier versions of WC, before using this property in the tracker request.This PR also removes some not particularly helpful unit tests and avoids mocking the
WooPay_Trackersystem under test.Testing instructions
store_idvalue should now benull.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge