WeChat Pay intent confirmation and error handling #10442
+57
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +843 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
mdmoore
commented
Feb 26, 2025
| @@ -180,7 +180,12 @@ public function update_order_status_from_intent( $order, $intent ) { | |||
| break; | |||
| case Intent_Status::REQUIRES_ACTION: | |||
| case Intent_Status::REQUIRES_PAYMENT_METHOD: | |||
| $this->mark_payment_started( $order, $intent_data ); | |||
| if ( ! empty( $intent_data['error'] ) ) { | |||
| $this->unlock_order_payment( $order ); | |||
There was a problem hiding this comment.
It's necessary to unlock the order here due to the order_prepared_for_processing() call above, which locks the order while running the check. mark_payment_failed() runs the same check again which bails if the order is locked.
mdmoore
commented
Feb 26, 2025
Comment on lines
+290
to
+293
| if ( paymentError ) { | ||
| throw paymentError; | ||
| } | ||
|
|
There was a problem hiding this comment.
This error is thrown after the ajax call to ensure the order status updates for failed orders.
mdmoore
requested review from
a team and
timur27
and removed request for
a team
timur27
reviewed
Feb 27, 2025
| @@ -199,6 +199,18 @@ export default class WCPayAPI { | |||
| ).confirmCardPayment( clientSecret ); | |||
| } | |||
|
|
|||
| if ( paymentMethodType === 'wechat_pay' ) { | |||
| const confirmPayment = await stripe.confirmWechatPayPayment( | |||
There was a problem hiding this comment.
Stripe docs suggest using confirmWechatPayPayment for confirmation, but the flow looks almost identical for me when using handleNextActions. Almost, because there's an extra redirect from the third-party page upon authorization/failure when using handleNextActions. The QR displays well with both.
Do we know if there is a real difference in flow handling with confirmWechatPayPayment? Using the streamlined handleNextActions would simplify the implementation. It solely depends on the API, and I'm not sure if we've asked Stripe about this?
Comment on lines
+267
to
+274
| return [ ajaxCall, paymentError || result.error ]; | ||
| } ) | ||
| .then( ( [ verificationCall, originalError ] ) => { | ||
| .then( ( res ) => { | ||
| const [ | ||
| verificationCall, | ||
| paymentError, | ||
| originalError, | ||
| ] = res; |
There was a problem hiding this comment.
Looking at the Promise chain, is there a reason for destructuring three elements while the returned array consists of two only? Does this code mean we effectively moved throwing the originalError to after the veriication call, as originalError is in fact paymentError now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10385
Changes proposed in this Pull Request
This is confirming the WeChat Pay intent using
stripe.confirmWechatPayPayment().Testing instructions
Local Server
${site_id}- your site's ID from the Jetpack connection - you can also get that value from you local table:wcpayserver/wcpay_accounts. wpcom_blog_id):npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge