dev - Fix the flaky test in WC_Payments_Incentives_Service_Test #10472
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
RadoslavGeorgiev
approved these changes
Feb 28, 2025
htdat
deleted the
dev/fix-unstable-test-WC_Payments_Incentives_Service_Test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error as seen in
https://github.com/Automattic/woocommerce-payments/actions/runs/13581864590/job/37969236625
Changes proposed in this Pull Request
This PR fixes the flaky test
test_get_connect_incentive_has_orders_is_cached_longer_when_has_ordersinWC_Payments_Incentives_Service_Testthat was failing intermittently due to timing precision issues. The test was asserting an exact match for cache expiration time (60 days in seconds), but due to the nature of PHP'stime()function and the slight delays between calculations, this could occasionally fail.The change modifies the test assertion to allow for a small tolerance (≤ 5 seconds) in the expiration time check, making the test more resilient while still maintaining its effectiveness in catching real issues.
There is an alternative approach by mocking
timefunctions like in the server repo but I don't want to make it complicated, and this is still good to address the root cause.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge